Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upgrade): ubuntu 24.04 LTS for base (was 22.04) #2907

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(upgrade): ubuntu 24.04 LTS for base (was 22.04) #2907

wants to merge 2 commits into from

Conversation

casaper
Copy link

@casaper casaper commented Jan 4, 2025 •
edited
Loading

Upgrade ubuntu base image to 24.04 LTS

Breaking change

No breaking change that I'd know of. Tested build and running only with linux/amd64 platform though.

Proposed change

Upgrade the ubuntu base image from 22.04 LTS to 24.04 LTS, and upgrade transmission to 4.0.6.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this container)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: relates to #
  • Link to documentation updated (if done separately): https://...

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

@casaper
Copy link
Author

casaper commented Jan 4, 2025

@haugene
I'm looking for the docker file of haugene/transmission-builder.
I think I need to update this image as well, in order to be able to upgrade to ubuntu base to 24.04 here.

AFAIS it isn't available in this repo.

Would you mind committing it to this repo, since it is obviously a dependency in Dockerfile#L45?

@casaper casaper force-pushed the feat/upgrade_ubuntu_to_24_04_LTS branch 2 times, most recently from e1e6ce2 to 0ce31e9 Compare January 4, 2025 17:20
@casaper
Copy link
Author

casaper commented Jan 4, 2025

@haugene

Would you mind committing it to this repo, since it is obviously a dependency in Dockerfile#L45?

I extracted what it aproximately is. But I lack that file you seem to have added with:

ADD file:5f73ea0f53302f1771b6d2cb5650f715247ad02d80e986d67b2d55c22712f1ca in /

I am not sure if I need it. Do I?

But looking at what I extracted, makes me think that this extra build image could be integrated as a pre stage of the main docker file of this repo anyway, if I'm not mistaken.

So there would be no extra dependency any more, right?

casaper added 2 commits January 4, 2025 18:31
@casaper
feat(upgrade): ubuntu base 24.04 LTS (was 22.04)
f109489 
- Upgrade the ubuntu base image to 24.04 LTS
- integrate the transmission build as build stage into the
  main Dockerfile, instead of seperate build image with missing dockerfile
- update defalult built transmission version to 4.0.6 (current stable)
@casaper
chore: add editorconfig file for convenience
e1844bc
@casaper casaper force-pushed the feat/upgrade_ubuntu_to_24_04_LTS branch from 0ce31e9 to e1844bc Compare January 4, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@casaper