Merge pull request #563 from Lezune/user/lezune/coderub-cleanup-v2101

CODE RUB: FollowUp CodeCleanUp V2.10.1
hassanhabib · Jun 13, 2024 · f0926e6 · f0926e6
2 parents 13ff551 + a7bf768
commit f0926e6
Show file tree

Hide file tree

Showing 21 changed files with 30 additions and 40 deletions.
diff --git a/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AIFiles/AIFileServiceTests.cs b/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AIFiles/AIFileServiceTests.cs
@@ -156,4 +156,4 @@ private Filler<AIFile> CreateAIFileFiller()
             return filler;
         }
     }
-}
+}
diff --git a/...d.AI.OpenAI.Tests.Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.cs b/...d.AI.OpenAI.Tests.Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.cs
@@ -157,4 +157,4 @@ private static Filler<ChatCompletion> ChatCompletionFiller()
             return filler;
         }
     }
-}
+}
diff --git a/....Tests.Unit/Services/Foundations/Completions/CompletionServiceTests.Validations.Prompt.cs b/....Tests.Unit/Services/Foundations/Completions/CompletionServiceTests.Validations.Prompt.cs
@@ -58,7 +58,8 @@ private async Task ShouldThrowValidationExceptionOnPromptIfRequestIsNullAsync()
             invalidCompletion.Request = null;
 
             var invalidCompletionException =
-                CreateInvalidCompletionException();
+                new InvalidCompletionException(
+                    message: "Invalid completion error occurred, fix errors and try again.");
 
             invalidCompletionException.AddData(
                 key: nameof(Completion.Request),
@@ -106,7 +107,8 @@ private async Task ShouldThrowValidationExceptionOnPromptIfCompletionIsInvalidAs
             };
 
             var invalidCompletionException =
-                CreateInvalidCompletionException();
+                new InvalidCompletionException(
+                    message: "Invalid completion error occurred, fix errors and try again.");
 
             invalidCompletionException.AddData(
                 key: nameof(CompletionRequest.Model),
@@ -150,7 +152,8 @@ private async Task ShouldThrowValidationExceptionOnPromptIfPromptIsEmptyAsync()
             };
 
             var invalidCompletionException =
-                CreateInvalidCompletionException();
+                new InvalidCompletionException(
+                    message: "Invalid completion error occurred, fix errors and try again.");
 
             invalidCompletionException.AddData(
                 key: nameof(CompletionRequest.Prompts),

diff --git a/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/Completions/CompletionServiceTests.cs b/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/Completions/CompletionServiceTests.cs
@@ -142,11 +142,5 @@ private static Filler<Completion> CreateCompletionFiller()
 
             return filler;
         }
-
-        private static InvalidCompletionException CreateInvalidCompletionException()
-        {
-            return new InvalidCompletionException(
-                message: "Invalid completion error occurred, fix errors and try again.");
-        }
     }
-}
+}
diff --git a/...enAI.Tests.Unit/Services/Foundations/FineTunes/FineTuneServiceTests.Validations.Submit.cs b/...enAI.Tests.Unit/Services/Foundations/FineTunes/FineTuneServiceTests.Validations.Submit.cs
@@ -61,7 +61,8 @@ private async Task ShouldThrowValidationExceptionOnSubmitIfFineTuneRequestIsNull
             fineTune.Request = nullFineTuneRequest;
 
             var invalidFineTuneException =
-                createInvalidFineTuneException();
+                new InvalidFineTuneException(
+                    message: "Fine tune is invalid.");
 
             invalidFineTuneException.AddData(
                 key: nameof(FineTune.Request),
@@ -106,7 +107,8 @@ private async Task ShouldThrowValidationExceptionOnSubmitIfFineTuneRequestIsInva
             invalidFineTune.Request = new FineTuneRequest();
             invalidFineTune.Request.FileId = invalidText;
             var invalidFineTuneException =
-                createInvalidFineTuneException();
+                new InvalidFineTuneException(
+                    message: "Fine tune is invalid.");
 
             invalidFineTuneException.AddData(
                 key: nameof(FineTuneRequest.FileId),

diff --git a/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/FineTunes/FineTuneServiceTests.cs b/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/FineTunes/FineTuneServiceTests.cs
@@ -187,11 +187,5 @@ private static Filler<FineTune> CreateRandomFineTuneFiller()
 
             return filler;
         }
-
-        private InvalidFineTuneException createInvalidFineTuneException()
-        {
-            return new InvalidFineTuneException(
-                message: "Fine tune is invalid.");
-        }
     }
 }
diff --git a/...Services/Foundations/ImageGenerations/ImageGenerationServiceTests.Validations.Generate.cs b/...Services/Foundations/ImageGenerations/ImageGenerationServiceTests.Validations.Generate.cs
@@ -59,7 +59,8 @@ private async Task ShouldThrowValidationExceptionOnGenerateIfRequestIsNullAsync(
             invalidImageGeneration.Request = null;
 
             var invalidImageGenerationException =
-                CreateInvalidImageGenerationException();
+                new InvalidImageGenerationException(
+                    message: "Invalid image generation error occurred, fix errors and try again.");
 
             invalidImageGenerationException.AddData(
                 key: nameof(ImageGeneration.Request),
@@ -107,7 +108,8 @@ private async Task ShouldThrowValidationExceptionOnGenerateIfRequestIsInvalidAsy
             };
 
             var invalidImageGenerationException =
-                CreateInvalidImageGenerationException();
+                new InvalidImageGenerationException(
+                    message: "Invalid image generation error occurred, fix errors and try again.");
 
             invalidImageGenerationException.AddData(
                 key: nameof(ImageGeneration.Request.Prompt),

diff --git a/...AI.OpenAI.Tests.Unit/Services/Foundations/ImageGenerations/ImageGenerationServiceTests.cs b/...AI.OpenAI.Tests.Unit/Services/Foundations/ImageGenerations/ImageGenerationServiceTests.cs
@@ -108,11 +108,5 @@ public static TheoryData UnauthorizedExceptions()
                 new HttpResponseForbiddenException()
             };
         }
-
-        private static InvalidImageGenerationException CreateInvalidImageGenerationException()
-        {
-            return new InvalidImageGenerationException(
-                message: "Invalid image generation error occurred, fix errors and try again.");
-        }
     }
 }
diff --git a/...I.OpenAI/Models/Services/Foundations/Completions/Exceptions/InvalidCompletionException.cs b/...I.OpenAI/Models/Services/Foundations/Completions/Exceptions/InvalidCompletionException.cs
@@ -12,6 +12,7 @@ public class InvalidCompletionException : Xeption
         public InvalidCompletionException(string message)
             : base(message)
         { }
+
         public InvalidCompletionException(string message, Exception innerException)
             : base(message, innerException)
         { }

diff --git a/...Services/Foundations/ImageGenerations/Exceptions/ExcessiveCallImageGenerationException.cs b/...Services/Foundations/ImageGenerations/Exceptions/ExcessiveCallImageGenerationException.cs
@@ -13,4 +13,4 @@ public ExcessiveCallImageGenerationException(string message, Exception innerExce
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/...I/Models/Services/Foundations/LocalFiles/Exceptions/FailedLocalFileDependencyException.cs b/...I/Models/Services/Foundations/LocalFiles/Exceptions/FailedLocalFileDependencyException.cs
@@ -13,4 +13,4 @@ public FailedLocalFileDependencyException(string message, Exception innerExcepti
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/...enAI/Models/Services/Foundations/LocalFiles/Exceptions/FailedLocalFileServiceException.cs b/...enAI/Models/Services/Foundations/LocalFiles/Exceptions/FailedLocalFileServiceException.cs
@@ -13,4 +13,4 @@ public FailedLocalFileServiceException(string message, Exception innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/....AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/InvalidLocalFileException.cs b/....AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/InvalidLocalFileException.cs
@@ -17,4 +17,4 @@ public InvalidLocalFileException(string message, Exception innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/....OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileDependencyException.cs b/....OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileDependencyException.cs
@@ -12,4 +12,4 @@ public LocalFileDependencyException(string message, Xeption innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/...dels/Services/Foundations/LocalFiles/Exceptions/LocalFileDependencyValidationException.cs b/...dels/Services/Foundations/LocalFiles/Exceptions/LocalFileDependencyValidationException.cs
@@ -12,4 +12,4 @@ public LocalFileDependencyValidationException(string message, Xeption innerExcep
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/....AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileServiceException.cs b/....AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileServiceException.cs
@@ -12,4 +12,4 @@ public LocalFileServiceException(string message, Xeption innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/....OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileValidationException.cs b/....OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/LocalFileValidationException.cs
@@ -12,4 +12,4 @@ public LocalFileValidationException(string message, Xeption innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/...AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/NotFoundLocalFileException.cs b/...AI.OpenAI/Models/Services/Foundations/LocalFiles/Exceptions/NotFoundLocalFileException.cs
@@ -13,4 +13,4 @@ public NotFoundLocalFileException(string message, Exception innerException)
             : base(message, innerException)
         { }
     }
-}
+}
diff --git a/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/AIFileOrchestrationService.Exceptions.cs b/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/AIFileOrchestrationService.Exceptions.cs
@@ -157,4 +157,4 @@ private static NullAIFileOrchestrationException CreateNullAIFileOrchestrationExc
                 message: "AI file is null.");
         }
     }
-}
+}
diff --git a/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/AIFileOrchestrationService.Validations.cs b/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/AIFileOrchestrationService.Validations.cs
@@ -70,4 +70,4 @@ private static void Validate(params (dynamic Rule, string Parameter)[] validatio
             invalidAIFileException.ThrowIfContainsErrors();
         }
     }
-}
+}
diff --git a/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/IAIFileOrchestrationService.cs b/Standard.AI.OpenAI/Services/Orchestrations/AIFiles/IAIFileOrchestrationService.cs
@@ -14,4 +14,4 @@ internal interface IAIFileOrchestrationService
         ValueTask<IEnumerable<AIFileResponse>> RetrieveAllFilesAsync();
         ValueTask<AIFile> RemoveFileByIdAsync(string fileId);
     }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -156,4 +156,4 @@ private Filler<AIFile> CreateAIFileFiller() @@
                 return filler;
             }
         }
-    }
+    }