Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote .server.ha.clusterAddr value #810

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Quote .server.ha.clusterAddr value #810

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e171574
Quote custom `VAULT_CLUSTER_ADDR` value
justusbunsi Aug 30, 2022
2bad222
Merge remote-tracking branch 'origin/main' into bug/quote-cluster-addr
justusbunsi Nov 3, 2022
290765e
Add unit test to prevent regressions
justusbunsi Nov 8, 2022
06a23d6
changelog++
tvoran Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test to prevent regressions
  • Loading branch information
@justusbunsi
justusbunsi committed Nov 8, 2022
commit 290765e6eeacf281be05160aae7e220df948a27d
16 changes: 16 additions & 0 deletions test/unit/server-ha-statefulset.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,22 @@ load _helpers
[ "${value}" = 'http://$(HOSTNAME).release-name-vault-internal:8201' ]
}

@test "server/ha-StatefulSet: clusterAddr gets quoted" {
cd `chart_dir`
local customUrl='http://$(HOSTNAME).release-name-vault-internal:8201'
local rendered=$(helm template \
--show-only templates/server-statefulset.yaml \
--set 'server.ha.enabled=true' \
--set 'server.ha.raft.enabled=true' \
--set "server.ha.clusterAddr=${customUrl}" \
. | tee /dev/stderr | \
grep -F "${customUrl}" | tee /dev/stderr)

local value=$(echo $rendered |
yq -Y '.' | tee /dev/stderr)
[ "${value}" = 'value: "http://$(HOSTNAME).release-name-vault-internal:8201"' ]
}

#--------------------------------------------------------------------
# VAULT_RAFT_NODE_ID renders

Expand Down