Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of agent: add disable_keep_alives configurable into release/1.11.x #16493

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Backport of agent: add disable_keep_alives configurable into release/1.11.x #16493

merged 1 commit into from
Jul 28, 2022

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16479 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.

Follow up for #15986.

This PR adds a new configurable, disable_keep_alives, which takes a string list to disable keep alives for various features in Vault Agent (auto-auth, caching and templating).

A small example can be found here:

 "auto_auth" = {
  "method" = {
    "config" = {
      "role" = "app"
    }
    "type" = "kubernetes"
  }

  "sink" = {
    "config" = {
      "path" = "/home/vault/.token"
    }
    "type" = "file"
  }
}

"disable_idle_connections" = ["auto-auth", "caching", "templating"]
"disable_keep_alives" = ["auto-auth", "caching", "templating"]
"exit_after_auth" = false
"pid_file" = "/home/vault/.pid"

"template" = {
  "contents" = "{{ with secret \"secret/hashiconf\" }}{{ .Data | toJSONPretty }}{{ end }}"
  "destination" = "/vault/secrets/kv-secret"
  "error_on_missing_key" = true
}

"vault" = {
  "address" = "https://vault.vault.svc.cluster.local:8200"
}
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core requested a review from a team July 28, 2022 20:00
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/disable-keep-alives/horribly-pumped-chow branch from 1212474 to a2407b2 Compare July 28, 2022 20:00
@swenson swenson enabled auto-merge (squash) July 28, 2022 20:35
@swenson swenson merged commit 79a5725 into release/1.11.x Jul 28, 2022
@swenson swenson deleted the backport/disable-keep-alives/horribly-pumped-chow branch July 28, 2022 20:35
@calvn calvn added this to the 1.11.2 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@taoism4504 taoism4504 Awaiting requested review from taoism4504

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-secure-vault-core @swenson @calvn @jasonodonnell