Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Premature Rotation For autorotate #12563

Merged
merged 29 commits into from
Sep 22, 2021
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b90bbd2
port of ldap fix for early cred rotation
Sep 15, 2021
b4fa49a
some more porting
Sep 15, 2021
f603227
another couple lines to port
Sep 15, 2021
ade88b4
final commits before report
Sep 15, 2021
cd4b897
remove deadlock
Sep 15, 2021
61882c1
needs testing
Sep 15, 2021
73fc684
updates
Sep 16, 2021
01eae5d
Sync with OpenLDAP PR
tomhjp Sep 16, 2021
6756417
Update the update error handling for items not found in the queue
tomhjp Sep 17, 2021
584c65c
WIP unit tests
tomhjp Sep 17, 2021
a5de7c3
throw error on role creation failure
Sep 17, 2021
b1c8a06
do not swallow error on role creation
Sep 17, 2021
271831e
Merge branch 'vault-2485' of github.com:hashicorp/vault into vault-2485
Sep 17, 2021
a85bda7
comment out wip tests and add in a test for disallowed role
Sep 17, 2021
b07aa53
Use newly generated password in WAL
Sep 17, 2021
7649297
return err on popFromRotationQueueByKey error; cleanup on setStaticAc…
calvn Sep 20, 2021
747e0ee
test: fix TestPlugin_lifecycle
calvn Sep 20, 2021
9cd86cb
Uncomment and fix unit tests
tomhjp Sep 21, 2021
63c3d0c
Undo logging updates
tomhjp Sep 21, 2021
45af160
Add changelog
tomhjp Sep 21, 2021
0c01226
Remove ticker and background threads from WAL tests
tomhjp Sep 21, 2021
166fe7d
Keep pre-existing API behaviour of allowing update static role to act…
tomhjp Sep 21, 2021
5b88f40
Switch test back to update operation
tomhjp Sep 21, 2021
a6765ff
Revert my revert, and fix some test bugs
tomhjp Sep 21, 2021
52137e6
Fix TestBackend_StaticRole_LockRegression
tomhjp Sep 21, 2021
83e9387
clean up defer on TestPlugin_lifecycle
calvn Sep 21, 2021
7c29a76
unwrap reqs on cleanup
calvn Sep 21, 2021
dec64cd
setStaticAccount: don't hold a write lock
calvn Sep 21, 2021
9e0c962
TestStoredWALsCorrectlyProcessed: set replication state to unknown
calvn Sep 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove deadlock
HridoyRoy committed Sep 15, 2021
commit cd4b897e5dcd7b26a86a0968cebf0f3337445c86
2 changes: 0 additions & 2 deletions builtin/logical/database/rotation.go
Original file line number Diff line number Diff line change
@@ -312,8 +312,6 @@ func (b *databaseBackend) setStaticAccount(ctx context.Context, s logical.Storag
if input == nil || input.Role == nil || input.RoleName == "" {
return output, errors.New("input was empty when attempting to set credentials for static account")
}
b.Lock()
defer b.Unlock()

dbConfig, err := b.DatabaseConfig(ctx, s, input.Role.DBName)
if err != nil {