Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for not_after in the PKI sign intermediate endpoint #2385

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for not_after in the PKI sign intermediate endpoint #2385

wants to merge 4 commits into from
+80 −16

Conversation

rculpepper
Copy link
Contributor

Description

This updates the PKI sign intermediate resource to support the not_after field.

Closes #1991

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@rculpepper rculpepper requested a review from a team December 20, 2024 15:51
@rculpepper rculpepper requested a review from a team as a code owner December 20, 2024 15:51
@rculpepper rculpepper requested a review from lursu December 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lursu lursu Awaiting requested review from lursu lursu is a code owner automatically assigned from hashicorp/vault

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: support not_after on vault_pki_secret_backend_root_sign_intermediate
1 participant
@rculpepper