Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure for the kv-v2 mounts #1311

Closed
wants to merge 2 commits into from
Closed

Add ability to configure for the kv-v2 mounts #1311

wants to merge 2 commits into from

Conversation

harsimranmaan
Copy link

@harsimranmaan harsimranmaan commented Jan 19, 2022 •
edited
Loading

Add a new resource and datasource to configure kv-v2.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1310

Release note for CHANGELOG:

To be updated after the next unreleased version is set in the Changelog file

Output from acceptance testing:

$ TESTARGS="--run KvV2Config" make testacc
ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestAccKvV2ConfigDataSource_basic
--- PASS: TestAccKvV2ConfigDataSource_basic (3.78s)
=== RUN   TestAccKvV2ConfigDataSource_full
--- PASS: TestAccKvV2ConfigDataSource_full (2.34s)
=== RUN   TestAccKvV2Config_import
--- PASS: TestAccKvV2Config_import (1.64s)
=== RUN   TestAccKvV2Config_fullUpdate
--- PASS: TestAccKvV2Config_fullUpdate (4.39s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     15.318s

@harsimranmaan harsimranmaan force-pushed the kv_v2_config branch 2 times, most recently from 6fa276e to 2a4eb5e Compare January 19, 2022 23:53
@harsimranmaan harsimranmaan mentioned this pull request Jan 19, 2022
Closed
@harsimranmaan
Add ability to configure for the kv-v2 mounts
de891dd 
Add a new resource and datasource to configure kv-v2.
@harsimranmaan
Add changelog entry
2cf44d0
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vinay-gopalan
Copy link
Contributor

Hi @harsimranmaan, thanks for submitting the PR! As of v3.7.0, the TFVP now supports configuring the KV V2 Backend using the vault_kv_secret_backend_v2 resource. This feature was added alongside other KV ecosystem resources in #1457

Going to close this PR, but feel free to open an issue if you face any problems with the new resources. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ability to configure for the kv-v2 mounts
3 participants
@harsimranmaan @hashicorp-cla @vinay-gopalan