Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Reduce uses of resource.TestCheckResourceAttrSet with ARN attributes: b and c services #40854

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

testing: Reduce uses of resource.TestCheckResourceAttrSet with ARN attributes: b and c services #40854

wants to merge 12 commits into from
+257 −76

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jan 9, 2025

Description

Reduce uses of resource.TestCheckResourceAttrSet on ARN attributes in favour of explicit checks

Addresses b and most of the c services

@gdavison gdavison requested a review from a team as a code owner January 9, 2025 21:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/configservice Issues and PRs that pertain to the configservice service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/batch Issues and PRs that pertain to the batch service. service/backup Issues and PRs that pertain to the backup service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/amp Issues and PRs that pertain to the amp service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 9, 2025
ewbankkit
ewbankkit approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/amp Issues and PRs that pertain to the amp service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit