Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_task_definition: Correctly detect volume differences #40853

Merged
merged 13 commits into from
Jan 10, 2025

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 9, 2025

Description

Correctly detect differences in volume.configure_at_launch and volume.docker_volume_configuration.

Relations

Closes #40801.
Closes #15810.
Closes #38153.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccECSTaskDefinition_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSTaskDefinition_ -timeout 360m
2025/01/09 14:50:45 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
=== PAUSE TestAccECSTaskDefinition_fsxWinFileSystem
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== RUN   TestAccECSTaskDefinition_unknownContainerDefinitions
=== PAUSE TestAccECSTaskDefinition_unknownContainerDefinitions
=== RUN   TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== PAUSE TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== RUN   TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== PAUSE TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== RUN   TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== PAUSE TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== RUN   TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== PAUSE TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== RUN   TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== PAUSE TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== RUN   TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== PAUSE TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_constraint
=== CONT  TestAccECSTaskDefinition_unknownContainerDefinitions
--- PASS: TestAccECSTaskDefinition_unknownContainerDefinitions (12.07s)
=== CONT  TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
--- PASS: TestAccECSTaskDefinition_constraint (14.05s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
--- PASS: TestAccECSTaskDefinition_basic (20.46s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
--- PASS: TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch (12.08s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
--- PASS: TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts (18.05s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled (16.92s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionNullPortMapping
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull (17.14s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionDockerLabels
--- PASS: TestAccECSTaskDefinition_containerDefinitionNullPortMapping (9.54s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_containerDefinitionDockerLabels (9.64s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency (25.41s)
=== CONT  TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
--- PASS: TestAccECSTaskDefinition_tags (43.74s)
=== CONT  TestAccECSTaskDefinition_trackLatest
--- PASS: TestAccECSTaskDefinition_trackLatest (16.19s)
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (0.79s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_basic (16.94s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (12.90s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression (81.64s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_executionRole (14.57s)
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
--- PASS: TestAccECSTaskDefinition_proxy (23.55s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (12.13s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings (117.97s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_arrays (12.03s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (9.46s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (20.66s)
=== CONT  TestAccECSTaskDefinition_fsxWinFileSystem
--- PASS: TestAccECSTaskDefinition_pidMode (12.82s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_ipcMode (13.02s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (25.41s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_networkMode (12.69s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (20.98s)
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_service (111.09s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_taskRoleARN (12.46s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_runtimePlatform (12.20s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (21.34s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (12.32s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (21.12s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (11.83s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (20.88s)
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (19.43s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (11.84s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (12.11s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_scratchVolume (12.34s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (12.44s)
--- PASS: TestAccECSTaskDefinition_disappears (17.43s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (4283.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	4474.010s

% make testacc TESTARGS='-run=TestAccECSTaskDefinition_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSTaskDefinition_ -timeout 360m
2025/01/08 14:22:40 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
=== PAUSE TestAccECSTaskDefinition_fsxWinFileSystem
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== RUN   TestAccECSTaskDefinition_unknownContainerDefinitions
=== PAUSE TestAccECSTaskDefinition_unknownContainerDefinitions
=== RUN   TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== PAUSE TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== RUN   TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== PAUSE TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== RUN   TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== PAUSE TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== RUN   TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== PAUSE TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_taskRoleARN (17.88s)
=== CONT  TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
--- PASS: TestAccECSTaskDefinition_basic (25.96s)
=== CONT  TestAccECSTaskDefinition_unknownContainerDefinitions
--- PASS: TestAccECSTaskDefinition_unknownContainerDefinitions (14.12s)
=== CONT  TestAccECSTaskDefinition_trackLatest
--- PASS: TestAccECSTaskDefinition_trackLatest (14.22s)
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (0.83s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (14.68s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_proxy (24.95s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression (77.54s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_constraint (13.47s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings (109.15s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (19.33s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_ipcMode (12.61s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_pidMode (12.97s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_networkMode (12.95s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (9.64s)
=== CONT  TestAccECSTaskDefinition_fsxWinFileSystem
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (20.70s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (26.07s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (21.84s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (21.77s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (21.63s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_service (112.01s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_executionRole (13.06s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (21.28s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency (24.63s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
--- PASS: TestAccECSTaskDefinition_tags (37.65s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled (16.83s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull (17.01s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_arrays (11.85s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (11.77s)
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (11.83s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (11.94s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (11.89s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionNullPortMapping
--- PASS: TestAccECSTaskDefinition_Fargate_basic (15.26s)
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_containerDefinitionNullPortMapping (9.39s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (12.10s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (11.81s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_scratchVolume (12.32s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionDockerLabels
--- PASS: TestAccECSTaskDefinition_disappears (17.23s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_containerDefinitionDockerLabels (9.47s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (12.52s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (4401.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	4543.551s
% make testacc TESTARGS='-run=TestAccECSTaskDefinition_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSTaskDefinition_ -timeout 360m
2025/01/09 10:26:38 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
=== PAUSE TestAccECSTaskDefinition_fsxWinFileSystem
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== RUN   TestAccECSTaskDefinition_unknownContainerDefinitions
=== PAUSE TestAccECSTaskDefinition_unknownContainerDefinitions
=== RUN   TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== PAUSE TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
=== RUN   TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== PAUSE TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
=== RUN   TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== PAUSE TestAccECSTaskDefinition_containerDefinitionDockerLabels
=== RUN   TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== PAUSE TestAccECSTaskDefinition_containerDefinitionNullPortMapping
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
=== RUN   TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== PAUSE TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
=== CONT  TestAccECSTaskDefinition_containerDefinitionDockerLabels
--- PASS: TestAccECSTaskDefinition_containerDefinitionDockerLabels (10.78s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (13.24s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull
--- PASS: TestAccECSTaskDefinition_basic (20.80s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionVersionConsistency
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled (16.96s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionNullPortMapping
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull (17.04s)
=== CONT  TestAccECSTaskDefinition_fsxWinFileSystem
--- PASS: TestAccECSTaskDefinition_containerDefinitionNullPortMapping (9.58s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency (24.53s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_proxy (23.09s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_executionRole (12.74s)
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
--- PASS: TestAccECSTaskDefinition_tags (37.62s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (11.92s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_arrays (12.13s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_Fargate_basic (15.26s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_constraint (13.61s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (19.43s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_pidMode (12.68s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_ipcMode (12.73s)
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_networkMode (12.82s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_taskRoleARN (12.78s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (9.52s)
=== CONT  TestAccECSTaskDefinition_unknownContainerDefinitions
--- PASS: TestAccECSTaskDefinition_unknownContainerDefinitions (11.62s)
=== CONT  TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings
--- PASS: TestAccECSTaskDefinition_service (102.52s)
=== CONT  TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression
--- PASS: TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings (111.52s)
=== CONT  TestAccECSTaskDefinition_trackLatest
--- PASS: TestAccECSTaskDefinition_trackLatest (13.51s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (13.66s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression (80.30s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (25.89s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (20.63s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (21.23s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (20.89s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (21.75s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (21.46s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (12.40s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_runtimePlatform (12.48s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (12.61s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_scratchVolume (12.52s)
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (12.56s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (12.51s)
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (0.76s)
--- PASS: TestAccECSTaskDefinition_disappears (17.56s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3998.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	4034.570s
% make testacc TESTARGS='-run=TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts -timeout 360m
2025/01/09 12:35:20 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== PAUSE TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== CONT  TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
--- PASS: TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts (19.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	25.183s
% make testacc TESTARGS='-run=TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch -timeout 360m
2025/01/09 14:43:20 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== PAUSE TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== CONT  TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
--- PASS: TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch (12.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	18.183s
@ewbankkit ewbankkit requested a review from a team as a code owner January 9, 2025 19:49
@ewbankkit ewbankkit changed the title r/aws_ecs_task_definition: Correctly volume differences r/aws_ecs_task_definition: Correctly detect volume differences Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 9, 2025
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jan 9, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ecs TESTS="TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts|TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts|TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch'  -timeout 360m
2025/01/10 14:43:26 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== PAUSE TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== RUN   TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== PAUSE TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
=== CONT  TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts
=== CONT  TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch
--- PASS: TestAccECSTaskDefinition_Volume_detectChangeInConfigureAtLaunch (14.31s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_detectChangeInDriverOpts (21.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        26.603s

@ewbankkit ewbankkit merged commit 6170ceb into main Jan 10, 2025
37 checks passed
@ewbankkit ewbankkit deleted the b-aws_ecs_task_definition.volume-diffs branch January 10, 2025 19:47
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 10, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants