Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves API inputs off of heap: apigateway #40845

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Moves API inputs off of heap: apigateway #40845

merged 3 commits into from
Jan 14, 2025

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jan 8, 2025

Description

Moves API inputs off of heap for apigateway

@gdavison gdavison requested a review from a team as a code owner January 8, 2025 23:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 8, 2025
ewbankkit
ewbankkit approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

Maybe add something to the Contributor's Guide to capture this emerging pattern?

@gdavison gdavison merged commit 6a81718 into main Jan 14, 2025
37 checks passed
@gdavison gdavison deleted the td-more-api-inputs-in-heap branch January 14, 2025 18:39
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 14, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 16, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/apigateway Issues and PRs that pertain to the apigateway service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.84.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit