Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticache): Make engine name case insensitive for user and user_group #40794

Merged
merged 2 commits into from
Jan 15, 2025
Merged

feat(elasticache): Make engine name case insensitive for user and user_group #40794

merged 2 commits into from
Jan 15, 2025

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented Jan 7, 2025

From what I can tell, the name isn't case sensitive, and even if you set it with the uppercase version, AWS will return the lowercase version (and the diff was already case-insensitive).

@tmccombs tmccombs requested a review from a team as a code owner January 7, 2025 00:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. needs-triage Waiting for first response or review from a maintainer. labels Jan 7, 2025
@tmccombs
feat(elasticache): Make engine name case insensitive for user and use…
f7fcc74 
…r_group

From what I can tell, the name isn't case sensitive, and even if you set it with the uppercase
version, AWS will return the lowercase version (and the diff was already case-insensitive).
@tmccombs tmccombs force-pushed the f-elasticache-user-case-insensitive branch from f0a5d23 to f7fcc74 Compare January 7, 2025 00:16
@gdavison
Copy link
Contributor

gdavison commented Jan 7, 2025

Thanks for submitting this, @tmccombs. The acceptance tests and documentation examples should be updated to use the lowercase versions, for consistency with the other resource types for this service

@gdavison gdavison self-assigned this Jan 7, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 7, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 9, 2025
gdavison
gdavison approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @tmccombs 🚀

--- PASS: TestAccElastiCacheCluster_Memcached_finalSnapshot (30.77s)
--- PASS: TestAccElastiCacheUser_iamAuthMode (163.59s)
--- PASS: TestAccElastiCacheUserDataSource_basic (132.87s)
--- SKIP: TestAccElastiCacheCluster_outpostID_redis (0.11s)
--- SKIP: TestAccElastiCacheCluster_outpostID_memcached (0.11s)
--- SKIP: TestAccElastiCacheCluster_outpost_redis (0.09s)
--- SKIP: TestAccElastiCacheCluster_outpost_memcached (0.09s)
--- PASS: TestAccElastiCacheUser_passwordAuthMode (227.22s)
--- PASS: TestAccElastiCacheUser_basic (227.80s)
--- PASS: TestAccElastiCacheUserGroup_disappears (288.19s)
--- PASS: TestAccElastiCacheUser_updateEngine (289.37s)
--- PASS: TestAccElastiCacheUser_oobModify (290.07s)
--- PASS: TestAccElastiCacheUser_tags (291.35s)
--- PASS: TestAccElastiCacheUser_update (292.58s)
--- PASS: TestAccElastiCacheUserGroup_basic (292.84s)
--- PASS: TestAccElastiCacheUser_disappears (320.75s)
--- PASS: TestAccElastiCacheUserGroupAssociation_disappears (352.39s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_redis (5.32s)
--- PASS: TestAccElastiCacheUser_updatePasswordAuthMode (408.05s)
--- PASS: TestAccElastiCacheUserGroup_tags (408.64s)
--- PASS: TestAccElastiCacheUserGroupAssociation_basic (408.93s)
--- PASS: TestAccElastiCacheUserGroup_update (533.36s)
--- PASS: TestAccElastiCacheUserGroupAssociation_update (534.15s)
--- PASS: TestAccElastiCacheUserGroupAssociation_multiple (537.99s)
--- PASS: TestAccElastiCacheClusterDataSource_basic (709.96s)
--- PASS: TestAccElastiCacheCluster_TransitEncryption (756.54s)
--- PASS: TestAccElastiCacheCluster_tags (736.27s)
--- PASS: TestAccElastiCacheCluster_PortRedis_default (640.61s)
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (782.05s)
--- PASS: TestAccElastiCacheCluster_port (662.63s)
--- PASS: TestAccElastiCacheCluster_Redis_finalSnapshot (921.67s)
--- PASS: TestAccElastiCacheCluster_ipDiscovery (680.41s)
--- PASS: TestAccElastiCacheCluster_snapshotsWithUpdates (776.42s)
--- PASS: TestAccElastiCacheCluster_Engine_None (3.47s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_decrease (909.71s)
--- PASS: TestAccElastiCacheCluster_ParameterGroupName_default (687.20s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones (1416.41s)
--- PASS: TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations (1189.29s)
--- PASS: TestAccElastiCacheCluster_AZMode_memcached (683.31s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_memcached (1335.69s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increase (1227.77s)
--- PASS: TestAccElastiCacheCluster_AZMode_redis (722.40s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_singleReplica (1506.84s)
--- PASS: TestAccElastiCacheCluster_tagWithOtherModification (1676.41s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone (1536.55s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_redis (1541.07s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption (1609.05s)
--- PASS: TestAccElastiCacheCluster_disappears (718.96s)
--- PASS: TestAccElastiCacheCluster_vpc (750.33s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica (1682.10s)
--- PASS: TestAccElastiCacheCluster_Engine_memcached (662.90s)
--- PASS: TestAccElastiCacheCluster_multiAZInVPC (790.24s)
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (712.01s)
--- PASS: TestAccElastiCacheCluster_Engine_redis (732.76s)
--- PASS: TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations (985.28s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_memcached (1432.38s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_redis (4786.81s)

@gdavison gdavison merged commit 6fdda48 into hashicorp:main Jan 15, 2025
50 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 15, 2025
@tmccombs tmccombs deleted the f-elasticache-user-case-insensitive branch January 15, 2025 03:16
ewbankkit added a commit that referenced this pull request Jan 15, 2025
@ewbankkit
Tidy up CHANGELOG entries (#40794).
7796a06
@ewbankkit ewbankkit mentioned this pull request Jan 15, 2025
Merged
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 16, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Milestone
v5.84.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tmccombs @gdavison @justinretzolk