Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aws_dataexchange_job & aws_dataexchange_event_action #40422

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add aws_dataexchange_job & aws_dataexchange_event_action #40422

wants to merge 3 commits into from

Conversation

TSKnuhtsen
Copy link

Description

This PR adds a resource for aws_dataexchange_job and aws_dataexchange_event_action

Relations

Closes #40418

Output from Acceptance Testing

thyge@u5f9f1f071ee45a:~/development/clone/terraform-provider-aws$ make testacc TESTS=TestAccDataExchangeJob_* PKG=dataexchange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeJob_*'  -timeout 360m
2024/12/03 16:51:10 Initializing Terraform AWS Provider...
=== RUN   TestAccDataExchangeJob_importAssetsFromS3basic
--- PASS: TestAccDataExchangeJob_importAssetsFromS3basic (17.00s)
=== RUN   TestAccDataExchangeJob_importAssetsFromS3PostponeStart
--- PASS: TestAccDataExchangeJob_importAssetsFromS3PostponeStart (28.93s)
=== RUN   TestAccDataExchangeJob_exportAssetsToS3Basic
--- PASS: TestAccDataExchangeJob_exportAssetsToS3Basic (26.23s)
=== RUN   TestAccDataExchangeJob_exportAssetsToSignedUrl
--- PASS: TestAccDataExchangeJob_exportAssetsToSignedUrl (22.25s)
=== RUN   TestAccDataExchangeJob_importAssetFromSignedUrl
--- PASS: TestAccDataExchangeJob_importAssetFromSignedUrl (13.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	107.958s
thyge@u5f9f1f071ee45a:~/development/clone/terraform-provider-aws$ make testacc TESTS=TestAccDataExchangeEventAction_* PKG=dataexchange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeEventAction_*'  -timeout 360m
2024/12/03 16:57:06 Initializing Terraform AWS Provider...
=== RUN   TestAccDataExchangeEventAction_basic
--- PASS: TestAccDataExchangeEventAction_basic (0.73s)
=== RUN   TestAccDataExchangeEventAction_full
--- PASS: TestAccDataExchangeEventAction_full (0.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	1.546s

...

@TSKnuhtsen TSKnuhtsen requested a review from a team as a code owner December 3, 2024 23:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dataexchange Issues and PRs that pertain to the dataexchange service. linter Pertains to changes to or issues with the various linters. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Dec 3, 2024
github-actions[bot]
github-actions bot reviewed Dec 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @TSKnuhtsen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. new-resource Introduces a new resource. service/dataexchange Issues and PRs that pertain to the dataexchange service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Data Exchange - Job & AWS Data Exchange - Event Action
2 participants
@TSKnuhtsen @justinretzolk