Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: CodeConnections #38678

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[New Resource]: CodeConnections #38678

wants to merge 10 commits into from
+2,404 −0

Conversation

ishiguro-junya
Copy link

@ishiguro-junya ishiguro-junya commented Aug 4, 2024 •
edited
Loading

Description

Added new resources since CodeStar Connections was renamed to CodeConnections and the service prefix changed.
The changes I made are basically just copying the content from CodeStar Connections and renaming it.

Relations

Closes #36671

References

https://docs.aws.amazon.com/dtconsole/latest/userguide/rename.html

Output from Acceptance Testing

% make testacc PKG=codeconnections

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/codeconnections/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccCodeConnectionsConnectionDataSource_basic
=== PAUSE TestAccCodeConnectionsConnectionDataSource_basic
=== RUN   TestAccCodeConnectionsConnectionDataSource_tags
=== PAUSE TestAccCodeConnectionsConnectionDataSource_tags
=== RUN   TestAccCodeConnectionsConnection_basic
=== PAUSE TestAccCodeConnectionsConnection_basic
=== RUN   TestAccCodeConnectionsConnection_hostARN
=== PAUSE TestAccCodeConnectionsConnection_hostARN
=== RUN   TestAccCodeConnectionsConnection_disappears
=== PAUSE TestAccCodeConnectionsConnection_disappears
=== RUN   TestAccCodeConnectionsConnection_tags
=== PAUSE TestAccCodeConnectionsConnection_tags
=== RUN   TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== RUN   TestAccCodeConnectionsHost_disappears
=== PAUSE TestAccCodeConnectionsHost_disappears
=== RUN   TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/use_fips_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar
--- PASS: TestEndpointConfiguration (0.69s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.05s)
    --- PASS: TestEndpointConfiguration/no_config (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.05s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.05s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.05s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
=== CONT  TestAccCodeConnectionsConnectionDataSource_basic
=== CONT  TestAccCodeConnectionsConnection_tags
=== CONT  TestAccCodeConnectionsHost_disappears
=== CONT  TestAccCodeConnectionsConnection_hostARN
=== CONT  TestAccCodeConnectionsHost_vpc
=== CONT  TestAccCodeConnectionsHost_basic
=== CONT  TestAccCodeConnectionsConnection_basic
=== CONT  TestAccCodeConnectionsConnection_disappears
=== CONT  TestAccCodeConnectionsConnectionDataSource_tags
=== NAME  TestAccCodeConnectionsHost_disappears
    host_test.go:68: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsHost_disappears (0.69s)
=== NAME  TestAccCodeConnectionsConnectionDataSource_tags
    connection_data_source_test.go:61: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnectionDataSource_tags (0.69s)
=== NAME  TestAccCodeConnectionsConnection_hostARN
    connection_test.go:67: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnection_hostARN (0.69s)
=== NAME  TestAccCodeConnectionsHost_basic
    host_test.go:33: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsHost_basic (0.69s)
=== NAME  TestAccCodeConnectionsConnectionDataSource_basic
    connection_data_source_test.go:26: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnectionDataSource_basic (0.69s)
=== NAME  TestAccCodeConnectionsConnection_tags
    connection_test.go:130: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnection_tags (0.69s)
=== NAME  TestAccCodeConnectionsConnection_basic
    connection_test.go:32: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnection_basic (0.69s)
=== NAME  TestAccCodeConnectionsHost_vpc
    host_test.go:95: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsHost_vpc (0.69s)
=== NAME  TestAccCodeConnectionsConnection_disappears
    connection_test.go:103: skipping tests; partition aws does not support codeconnections service
--- SKIP: TestAccCodeConnectionsConnection_disappears (0.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections        6.012s

@ishiguro-junya ishiguro-junya requested a review from a team as a code owner August 4, 2024 22:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2024
github-actions[bot]
github-actions bot reviewed Aug 4, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ishiguro-junya 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2024
@pkujala pkujala mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS CodeStar Connections renamed to AWS CodeConnections
2 participants
@ishiguro-junya @justinretzolk