Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Databrew Dataset resource type #38083

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feature: Databrew Dataset resource type #38083

wants to merge 32 commits into from
+801 −1

Conversation

diofeher
Copy link
Contributor

@diofeher diofeher commented Jun 23, 2024 •
edited
Loading

Description

Adds a new resource called Dataset to the DataBrew package.

This PR is built on top of #38068 , so it needs to be merged after the first one.

Relations

Relates to #38068 and #26324

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDataBrewDataset_basic PKG=databrew
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/databrew/... -v -count 1 -parallel 20 -run='TestAccDataBrewDataset_basic'  -timeout 360m
=== RUN   TestAccDataBrewDataset_s3Input
=== PAUSE TestAccDataBrewDataset_s3Input
=== CONT  TestAccDataBrewDataset_s3Input
--- PASS: TestAccDataBrewDataset_s3Input (79.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/databrew	83.740s
...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/databrew Issues and PRs that pertain to the databrew service. labels Jun 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 23, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@diofeher diofeher changed the title feature: Databrew Dataset feature: Databrew Dataset resource type Jun 23, 2024
@diofeher diofeher marked this pull request as ready for review June 23, 2024 14:22
@diofeher diofeher requested a review from a team as a code owner June 23, 2024 14:22
@diofeher
Copy link
Contributor Author

To create a map of parameters in the schema, I used this approach here https://discuss.hashicorp.com/t/terraform-plugin-framework-map-of-different-value-types/56421/4

@justinretzolk justinretzolk added new-resource Introduces a new resource. new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. new-resource Introduces a new resource. new-service Introduces a new service. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/databrew Issues and PRs that pertain to the databrew service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diofeher @justinretzolk