Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove worklink resources #37319

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove worklink resources #37319

wants to merge 6 commits into from

Conversation

DanielRieske
Copy link
Contributor

Description

Worklink has been deprecated for almost a year now and has been replaced by Workspaces Web.
The endpoints for Worklink has officially been deprecated and I confirmed in a ticket with AWS that these can't be used anymore.

image

I wonder whether this PR warrants a breaking change as the resources itself don't work anymore.

I will start working on the replacement service resources Workspaces Web

Relations

Relates: #30297

Closes #30298
Closes #36227

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/worklink Issues and PRs that pertain to the worklink service. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/workspacesweb Issues and PRs that pertain to the workspacesweb service. labels May 7, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 7, 2024
@DanielRieske DanielRieske changed the title feat: remove worklink resources Remove worklink resoures May 7, 2024
@DanielRieske DanielRieske changed the title Remove worklink resoures Remove worklink resources May 7, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 9, 2024
@ewbankkit ewbankkit added this to the v6.0.0 milestone May 9, 2024
This was referenced Sep 30, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/worklink Issues and PRs that pertain to the worklink service. service/workspacesweb Issues and PRs that pertain to the workspacesweb service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

WorkLink service end of life [AWS SDK for Go Migration] WorkLink Service
3 participants
@DanielRieske @ewbankkit @justinretzolk