Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #29791 #36961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issue #29791 #36961

wants to merge 2 commits into from
+2 −2

Conversation

robmoss2k
Copy link

Description

Adds AWAITING_APP_CNAME to the pending state for awaiting domain association verification and the target state for awaiting domain association creation.

Relations

Closes #29791

References

Output from Acceptance Testing

I'm on Windows. I couldn't get the tests to work. In WSL, I ran out of memory while trying to run it. If someone could run this, that would be excellent.

@robmoss2k
Fix issue hashicorp#29791
33bdd2a 
Adds `AWAITING_APP_CNAME` to the pending state for awaiting domain association verification and the target state for awaiting domain association creation.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/amplify Issues and PRs that pertain to the amplify service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2024
github-actions[bot]
github-actions bot reviewed Apr 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @robmoss2k 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2024
@MrLightful
Copy link

MrLightful commented Aug 29, 2024 •
edited
Loading

There's also a IMPORTING_CUSTOM_CERTIFICATE

Error: waiting for Amplify Domain Association (***/dizconto.com) create: unexpected state 
'IMPORTING_CUSTOM_CERTIFICATE', wanted target 'PENDING_VERIFICATION, PENDING_DEPLOYMENT, AVAILABLE'. 
last error: %!s(<nil>)

@robmoss2k
Copy link
Author

@romatallinn Added that to the draft PR, thanks. Still no idea how to get hold of someone capable of running the tests. I just tried and failed again.

@MrLightful
Copy link

MrLightful commented Aug 29, 2024 •
edited
Loading

Thanks. Can you drop docs on what tests exactly you need to run? I don't see them in contribution guides, besides the ones run automatically in CI. I'll see what I can do.

@MrLightful
Copy link

MrLightful commented Aug 29, 2024 •
edited
Loading

Yikes, found the aforementioned tests. Quite bulky to setup.

@robmoss2k can you mark MR as non-draft, maybe this will help a bit with visibility.

Guide: Raising a pull request

Once you believe your pull request is ready to be reviewed, ensure the pull request is not a draft pull request by marking it ready for review or removing [WIP] from the pull request title if necessary, and a maintainer will review it. Follow the checklists below to help ensure that your contribution can be easily reviewed and potentially merged.

@robmoss2k robmoss2k marked this pull request as ready for review August 30, 2024 08:11
@robmoss2k robmoss2k requested a review from a team as a code owner August 30, 2024 08:11
@robmoss2k
Copy link
Author

Marked as ready for review - thanks for the help, @romatallinn!

@davad
Copy link

davad commented Sep 17, 2024

Not sure if this was helpful or not, but I pulled the branch and ran tests. My team is also dealing with this bug.

I followed these steps in a fresh VM. Like @MrLightful said, it was pretty bulky to set up. I ran make build and make test. I did not run make testacc.

Running make build and make test was successful.

What else needs to be done to verify and merge this PR?

@gdavison gdavison self-assigned this Dec 16, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@gdavison gdavison

Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/amplify Issues and PRs that pertain to the amplify service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Amplify Domain Association fails with unexpected state AWAITING_APP_CNAME
5 participants
@robmoss2k @MrLightful @davad @gdavison @justinretzolk