Acceptance test config files proof of concept (mq) #36719
Draft
+5,160
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
the
prioritized
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
YakDriver
changed the title
YakDriver
changed the title
gdavison
reviewed
Apr 17, 2024
| @@ -0,0 +1,120 @@ | |||
| variable "exclude_zone_ids" { | |||
There was a problem hiding this comment.
Small nit, the standard name for this file is variables.tf
Comment on lines
+234
to
+235
| //Config: testAccConfigurationConfig_tags1(rName, "key1", "value1"), | ||
| ConfigDirectory: config.TestStepDirectory(), |
There was a problem hiding this comment.
In cases like this, where a particular configuration is reused, it might be worthwhile using a named configuration, with config.StaticDirectory or a custom config.TestStepConfigFunc
Comment on lines
+37
to
+62
| ConfigVariables: map[string]config.Variable{ | ||
| "exclude_zone_ids": config.ListVariable(config.StringVariable("usw2-az4"), config.StringVariable("usgw1-az2")), | ||
| "state": config.StringVariable("available"), | ||
| "name": config.StringVariable("opt-in-status"), | ||
| "values": config.ListVariable(config.StringVariable("opt-in-not-required")), | ||
| "cidr_block": config.StringVariable("10.0.0.0/16"), | ||
| "random_name": config.StringVariable(rName), | ||
| "vcount": config.IntegerVariable(2), | ||
| "cidr_block_2": config.StringVariable("0.0.0.0/0"), | ||
| "engine_type": config.StringVariable("ActiveMQ"), | ||
| "engine_version": config.StringVariable("5.17.6"), | ||
| "auto_minor_version_upgrade": config.BoolVariable(true), | ||
| "apply_immediately": config.BoolVariable(true), | ||
| "deployment_mode": config.StringVariable("ACTIVE_STANDBY_MULTI_AZ"), | ||
| "host_instance_type": config.StringVariable("mq.t2.micro"), | ||
| "day_of_week": config.StringVariable("TUESDAY"), | ||
| "time_of_day": config.StringVariable("02:00"), | ||
| "time_zone": config.StringVariable("CET"), | ||
| "publicly_accessible": config.BoolVariable(true), | ||
| "username": config.StringVariable("Ender"), | ||
| "password": config.StringVariable("AndrewWiggin"), | ||
| "username_2": config.StringVariable("Petra"), | ||
| "password_2": config.StringVariable("PetraArkanian"), | ||
| "console_access": config.BoolVariable(true), | ||
| "groups": config.ListVariable(config.StringVariable("dragon"), config.StringVariable("salamander"), config.StringVariable("leopard")), | ||
| }, |
There was a problem hiding this comment.
Do we need all of these variables, especially since the config is not being reused? The original testAccBrokerDataSourceConfig_byID took one parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR
"github.com/hashicorp/terraform-plugin-testing/helper/resource"supports acceptance testing using configuration files rather than strings. This PR takes an entire service, MQ, and converts all acceptance tests to use configuration files and shows what using config files entails. The tests run perfectly fine like this with a small hiccup (providerblocks).Advantages of Config Files:
Challenges with Config Files:
Relations
Closes #0000
References
Output from Acceptance Testing