Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates resource acceptance tests to Terraform 0.12 syntax, batch 3: EBS to GuardDuty #15070

Merged
merged 10 commits into from
Sep 14, 2020
Merged

Updates resource acceptance tests to Terraform 0.12 syntax, batch 3: EBS to GuardDuty #15070

merged 10 commits into from
Sep 14, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 8, 2020 •
edited
Loading

Updates resource acceptance tests to Terraform 0.12 syntax from EBS to GuardDuty

Relates #14722

Some additional changes:
Fixes #14987
Relates #13527

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAwsGlobalAcceleratorEndpointGroup\|TestResourceAWSElastiCacheReplicationGroupEngineValidation\|TestAccAWSEc2Fleet\|TestResourceAWSEFSFileSystem\|TestAccAWSEcsCluster\|TestAccAWSEMRCluster\|TestAccAWSFlowLog\|TestAccAWSEksFargateProfile\|TestAccAWSEIPAssociation\|TestAccAWSEIP\|TestAccAWSEIPAssociate\|TestAccAWSEc2TransitGatewayPeeringAttachment\|TestAccAWSEcsService\|TestAccAWSELBAttachment\|TestAccAWSEMRInstanceFleet\|TestAccAWSEc2TransitGatewayVpcAttachment\|TestAccAWSElasticacheCluster\|TestResourceAwsElbListenerHash\|TestResourceAWSELB\|TestAccAWSEc2TrafficMirrorTarget\|TestAccAWSEksNodeGroup\|TestAccAWSEMRInstanceGroup\|TestAccAWSElasticacheReplicationGroup\|TestAccAWSEcsCapacityProvider\|TestAccAWSELBUpdate\|TestAccAWSElasticacheSubnetGroup\|TestAccAWSEBSVolume\|TestAccAWSELB\|TestAccAWSEc2AvailabilityZoneGroup\|TestAccAWSEFSFileSystem\|TestAccAwsEmrManagedScalingPolicy\|TestAccAwsGlobalAcceleratorAccelerator"

--- SKIP: TestAccAWSOutpostsOutpostsDataSource_basic (2.33s)
--- PASS: TestAccAWSEBSVolume_basic (51.97s)
--- PASS: TestAccAWSEBSVolume_updateSize (83.20s)
--- PASS: TestAccAWSEBSVolume_updateType (85.60s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io1 (88.15s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (91.85s)
--- PASS: TestAccAWSEBSVolume_InvalidIopsForType (7.35s)
--- PASS: TestAccAWSEBSVolume_NoIops (29.77s)
--- PASS: TestAccAWSEBSVolume_kmsKey (33.33s)
--- SKIP: TestAccAWSEBSVolume_outpost (1.51s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io2 (65.70s)
--- PASS: TestAccAWSEBSVolume_withTags (33.13s)
--- PASS: TestAccAWSEBSVolume_multiAttach (31.76s)
--- PASS: TestAccAWSEc2AvailabilityZoneGroup_OptInStatus (16.94s)
--- PASS: TestAccAWSEBSVolume_disappears (25.65s)
--- PASS: TestAccAWSEc2Fleet_basic (33.10s)
--- PASS: TestAccAWSEc2Fleet_disappears (30.57s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (179.59s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateId (70.35s)
--- SKIP: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_MaxPrice (0.00s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateName (76.93s)
--- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (92.68s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_Version (72.85s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_AvailabilityZone (71.62s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_InstanceType (67.35s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority (66.51s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority_Multiple (72.29s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags (300.19s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_SubnetId (80.47s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity (80.36s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity_Multiple (77.81s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (308.97s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (309.50s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (311.74s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (317.36s)
--- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (79.36s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (353.55s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (354.69s)
--- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (91.54s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (53.94s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (54.14s)
--- PASS: TestAccAWSEc2Fleet_Type (48.63s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (84.07s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (85.19s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (80.87s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (90.99s)
--- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (85.28s)
--- PASS: TestAccAWSEc2Fleet_Tags (105.29s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (78.89s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (244.45s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (239.07s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (261.55s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_InitQuery (638.80s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (273.16s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout (674.75s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_Basic (681.61s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters (684.69s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent (703.08s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (300.83s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (322.54s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (334.28s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent (754.52s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (759.64s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (469.36s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (347.21s)
--- PASS: TestAccAWSEcsCapacityProvider_basic (54.53s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (55.99s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (51.70s)
--- PASS: TestAccAWSEcsCluster_basic (27.81s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (65.28s)
--- PASS: TestAccAWSEcsCluster_disappears (26.03s)
--- PASS: TestAccAWSEc2Fleet_TemplateMultipleNetworkInterfaces (532.93s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (98.14s)
--- PASS: TestAccAWSEcsCluster_Tags (66.01s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (228.66s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (58.81s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (95.45s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (315.38s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (258.02s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (344.89s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (377.94s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (74.58s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (103.10s)
--- FAIL: TestAccAWSEcsService_basicImport (78.09s)
--- PASS: TestAccAWSEcsCluster_containerInsights (92.47s)
--- PASS: TestAccAWSEcsService_disappears (69.24s)
--- PASS: TestAccAWSEcsService_withARN (108.79s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (79.01s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport (374.04s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support (380.93s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (92.18s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_differentAccount (684.26s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (51.84s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_Tags_sameAccount (713.67s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (70.19s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy_Type_Missing (1.63s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (58.72s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Tags (392.18s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_sameAccount (721.36s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (128.42s)
--- PASS: TestAccAWSEcsService_withIamRole (144.14s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (69.95s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (88.47s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (163.97s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (544.39s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation (411.51s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (64.93s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (472.85s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (70.81s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (195.09s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (94.57s)
--- PASS: TestResourceAWSEFSFileSystem_hasEmptyFileSystems (0.00s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (49.83s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (50.27s)
--- PASS: TestAccAWSEFSFileSystemPolicy_disappears (33.17s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (109.08s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation (495.59s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (121.26s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (90.30s)
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (27.27s)
--- PASS: TestAccAWSEcsService_ManagedTags (80.63s)
--- PASS: TestAccAWSEFSFileSystemPolicy_basic (74.02s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (238.93s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (56.13s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (152.84s)
--- PASS: TestAccAWSEFSFileSystem_disappears (29.44s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (81.13s)
--- PASS: TestAccAWSEcsService_withLbChanges (246.26s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (35.28s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (75.45s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (301.36s)
--- FAIL: TestAccAWSEFSFileSystem_lifecyclePolicy (56.53s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (79.62s)
--- PASS: TestAccAWSEcsService_Tags (148.26s)
--- FAIL: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (60.74s)
--- PASS: TestAccAWSEFSFileSystem_tags (110.32s)
--- PASS: TestAccAWSEFSFileSystem_basic (126.56s)
--- PASS: TestAccAWSEIP_basic (28.60s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (247.65s)
--- PASS: TestAccAWSEIP_disappears (19.78s)
--- PASS: TestAccAWSEIPAssociation_instance (82.97s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (178.72s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (1.89s)
--- PASS: TestAccAWSEcsService_withAlb (258.44s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (20.33s)
--- PASS: TestAccAWSEIP_networkInterface (52.81s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (199.06s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (57.19s)
--- FAIL: TestAccAWSEIPAssociation_ec2Classic (87.02s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (120.41s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (44.62s)
--- PASS: TestAccAWSEIP_tags_Vpc (55.91s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (94.27s)
--- PASS: TestAccAWSEIP_instance (93.42s)
--- PASS: TestAccAWSEIPAssociation_disappears (111.24s)
--- PASS: TestAccAWSEIPAssociation_basic (142.51s)
--- PASS: TestAccAWSEcsService_PropagateTags (240.09s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (116.18s)
--- PASS: TestAccAWSEIP_notAssociated (109.83s)
--- FAIL: TestAccAWSEIP_Ec2Classic (247.92s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (244.11s)
--- PASS: TestAccAWSEksNodeGroup_basic (1062.15s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1026.33s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (1040.30s)
--- PASS: TestAccAWSEksFargateProfile_disappears (1112.93s)
--- PASS: TestAccAWSEksFargateProfile_basic (1125.03s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1114.10s)
--- PASS: TestAccAWSEksFargateProfile_Selector_Labels (1144.22s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1112.04s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1073.63s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1173.31s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1148.69s)
--- PASS: TestAccAWSEksFargateProfile_Tags (1261.54s)
--- PASS: TestAccAWSEksNodeGroup_AmiType (1253.85s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1245.51s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1114.72s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1272.04s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1171.57s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1456.07s)
--- PASS: TestAccAWSElasticacheCluster_Port (410.77s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (443.64s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached (472.89s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis (2.72s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis (469.03s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (449.70s)
--- PASS: TestAccAWSElasticacheCluster_Port_Redis_Default (511.56s)
--- PASS: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (505.98s)
--- PASS: TestAccAWSElasticacheCluster_vpc (443.39s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached (453.11s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis (461.72s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (666.40s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (627.56s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (699.64s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (758.21s)
--- PASS: TestAccAWSEksNodeGroup_Tags (997.27s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (602.65s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (673.89s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (10.27s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached (1010.05s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis (992.58s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (812.75s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (692.92s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis (988.99s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached (1025.28s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (834.57s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (705.27s)
--- PASS: TestResourceAWSElastiCacheReplicationGroupEngineValidation (0.00s)
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (20.35s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica (1083.16s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (30.61s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone (1124.11s)
--- PASS: TestAccAWSELB_basic (21.26s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica (1113.26s)
--- PASS: TestAccAWSELB_disappears (14.29s)
--- PASS: TestAccAWSELB_fullCharacterRange (19.71s)
--- PASS: TestAccAWSELBAttachment_drift (94.77s)
--- PASS: TestAccAWSELB_namePrefix (20.14s)
--- PASS: TestAccAWSELB_AccessLogs_enabled (53.84s)
--- PASS: TestAccAWSELB_AccessLogs_disabled (51.17s)
--- PASS: TestAccAWSELB_generatedName (19.69s)
--- FAIL: TestAccAWSELBAttachment_basic (143.68s)
--- PASS: TestAccAWSELB_generatesNameForZeroValue (32.43s)
--- PASS: TestAccAWSELB_availabilityZones (64.49s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (897.42s)
--- PASS: TestAccAWSELB_tags (79.09s)
--- PASS: TestAccAWSELB_swap_subnets (64.42s)
--- PASS: TestAccAWSELB_HealthCheck (18.59s)
--- PASS: TestAccAWSELB_Timeout (21.40s)
--- PASS: TestAccAWSELBUpdate_HealthCheck (35.36s)
--- PASS: TestAccAWSELB_ConnectionDraining (18.06s)
--- PASS: TestAccAWSELBUpdate_Timeout (31.36s)
--- PASS: TestAccAWSELB_listener (89.04s)
--- PASS: TestResourceAwsElbListenerHash (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeginWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCanBeAnEmptyString (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeLongerThan32Characters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotEndWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateAccessLogsInterval (0.00s)
--- PASS: TestResourceAWSELB_validateHealthCheckTarget (0.00s)
--- PASS: TestAccAWSELB_InstanceAttaching (112.11s)
--- PASS: TestAccAWSELB_SecurityGroups (37.04s)
--- PASS: TestAccAWSELBUpdate_ConnectionDraining (47.85s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (692.48s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1120.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (749.39s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1079.87s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (747.80s)
--- PASS: TestAccAWSEMRCluster_disappears (392.86s)
--- PASS: TestAccAWSEMRCluster_basic (439.12s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (421.39s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (455.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (955.57s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (479.97s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (906.42s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (3453.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1759.58s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (474.85s)
--- FAIL: TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate (953.26s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (437.40s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (3815.05s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (1319.91s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (388.70s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (838.44s)
--- PASS: TestAccAWSEMRCluster_security_config (485.78s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (411.32s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (825.10s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1544.73s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1048.98s)
--- FAIL: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (790.13s)
--- PASS: TestAccAWSEMRCluster_keepJob (412.55s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (435.87s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (891.47s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (833.08s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (873.16s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1856.01s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (951.60s)
--- PASS: TestAccAWSEMRCluster_s3Logging (598.36s)
--- PASS: TestAccAWSEMRCluster_ebs_config (449.66s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1137.07s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (571.27s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (437.89s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (532.44s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (780.79s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (527.79s)
--- PASS: TestAccAWSEMRInstanceFleet_basic (461.49s)
--- PASS: TestAccAWSEMRCluster_tags (761.69s)
--- PASS: TestAccAWSEksNodeGroup_Version (3661.19s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (774.59s)
--- PASS: TestAccAWSEMRInstanceFleet_ebsBasic (487.53s)
--- PASS: TestAccAWSEMRInstanceFleet_full (481.48s)
--- PASS: TestAccAWSEMRInstanceFleet_disappears (481.99s)
--- PASS: TestAccAWSEMRInstanceFleet_zero_count (593.75s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1289.36s)
--- PASS: TestAccAwsEmrManagedScalingPolicy_ComputeLimits_MaximumCoreCapacityUnits (457.34s)
--- PASS: TestAccAwsEmrManagedScalingPolicy_basic (480.44s)
--- PASS: TestAccAwsEmrManagedScalingPolicy_ComputeLimits_MaximumOndemandCapacityUnits (479.66s)
--- PASS: TestAccAwsEmrManagedScalingPolicy_disappears (468.34s)
--- PASS: TestAccAWSEMRInstanceGroup_EmrClusterDisappears (632.72s)
--- PASS: TestAccAWSEMRInstanceGroup_basic (880.70s)
--- PASS: TestAccAWSEMRInstanceGroup_ConfigurationsJson (864.38s)
--- PASS: TestAccAWSEMRInstanceGroup_AutoScalingPolicy (995.57s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3255.19s)
--- PASS: TestAccAWSEMRInstanceGroup_EbsConfig_EbsOptimized (1128.23s)
--- PASS: TestAccAWSEMRInstanceGroup_BidPrice (1403.20s)
--- PASS: TestAccAWSEMRInstanceGroup_InstanceCount (1483.41s)

The following errors are pre-existing:

  • TestAccAWSEcsService_basicImport
  • TestAccAWSEFSFileSystem_lifecyclePolicy
  • TestAccAWSEFSFileSystem_lifecyclePolicy_removal
  • TestAccAWSEIPAssociation_ec2Classic
  • TestAccAWSEIP_Ec2Classic
  • TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups

Cannot reproduce the following errors locally or in Alt account:

  • TestAccAWSELBAttachment_basic
  • TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 8, 2020
@ghost ghost added the service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. label Sep 8, 2020
@gdavison gdavison added service/glue Issues and PRs that pertain to the glue service. service/guardduty Issues and PRs that pertain to the guardduty service. labels Sep 8, 2020
@gdavison gdavison changed the title Updates resource acceptance tests to Terraform 0.12 syntax, batch 3: EBS to ??? Updates resource acceptance tests to Terraform 0.12 syntax, batch 3: EBS to GuardDuty Sep 8, 2020
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/outposts Issues and PRs that pertain to the outposts service. and removed size/XL Managed by automation to categorize the size of a PR. labels Sep 9, 2020
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Sep 10, 2020
@gdavison gdavison marked this pull request as ready for review September 11, 2020 18:47
@gdavison gdavison requested a review from a team September 11, 2020 18:47
bflad
bflad approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if the acceptance testing passes same as before.

@gdavison gdavison merged commit cb3f809 into master Sep 14, 2020
@gdavison gdavison deleted the acctest-tflint-resources-part3 branch September 14, 2020 18:37
@gdavison gdavison added this to the v3.7.0 milestone Sep 14, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/guardduty Issues and PRs that pertain to the guardduty service. service/outposts Issues and PRs that pertain to the outposts service. service/rds Issues and PRs that pertain to the rds service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

Update aws_eip validation and documentation to prevent tagging non-VPC EIPs
2 participants
@gdavison @bflad