Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_iot_policy: Support resource import & ForceNew on name #13707

Merged
merged 3 commits into from
Jun 23, 2020
Merged

r/aws_iot_policy: Support resource import & ForceNew on name #13707

merged 3 commits into from
Jun 23, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13703.
Closes #11684.
Relates #13527.

Release note for CHANGELOG:

resource/aws_iot_policy: Support resource import
resource/aws_iot_policy: ForceNew on name changes

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIoTPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSIoTPolicy_ -timeout 120m
=== RUN   TestAccAWSIoTPolicy_basic
=== PAUSE TestAccAWSIoTPolicy_basic
=== RUN   TestAccAWSIoTPolicy_disappears
=== PAUSE TestAccAWSIoTPolicy_disappears
=== RUN   TestAccAWSIoTPolicy_invalidJson
=== PAUSE TestAccAWSIoTPolicy_invalidJson
=== CONT  TestAccAWSIoTPolicy_basic
=== CONT  TestAccAWSIoTPolicy_invalidJson
=== CONT  TestAccAWSIoTPolicy_disappears
--- PASS: TestAccAWSIoTPolicy_invalidJson (9.76s)
--- PASS: TestAccAWSIoTPolicy_disappears (17.98s)
--- PASS: TestAccAWSIoTPolicy_basic (23.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.993s

@ewbankkit ewbankkit requested a review from a team June 10, 2020 15:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 10, 2020
@ewbankkit ewbankkit force-pushed the f-aws_iot_policy-import branch from 5b46e23 to 352fbed Compare June 10, 2020 15:51
@ewbankkit ewbankkit changed the title r/aws_iot_policy: Support resource import r/aws_iot_policy: Support resource import & ForceNew on name Jun 10, 2020
@magiconair
Copy link

@ewbankkit My github client on iPhone gives me an option to merge this PR which I don't see here. Am I supposed to test and merge this?

@ewbankkit
Copy link
Contributor Author

@magiconair A Maintainer will merge the PR. Thanks.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2020
@bflad bflad self-assigned this Jun 22, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Jun 22, 2020
@bflad bflad added this to the v2.68.0 milestone Jun 22, 2020
bflad
bflad approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSIoTPolicy_invalidJson (3.85s)
--- PASS: TestAccAWSIoTPolicy_disappears (6.20s)
--- PASS: TestAccAWSIoTPolicy_basic (7.83s)

@bflad bflad merged commit 5ac8f89 into hashicorp:master Jun 23, 2020
bflad added a commit that referenced this pull request Jun 23, 2020
@bflad
Update CHANGELOG for #13707
e50d830
@ewbankkit ewbankkit deleted the f-aws_iot_policy-import branch June 23, 2020 12:07
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.68.0
Development

Successfully merging this pull request may close these issues.

aws_iot_policy doesn't support import Renaming aws_iot_policy does not work
3 participants
@ewbankkit @magiconair @bflad