Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ec2_capacity_reservation - add arn attribute + support for linux sql server instance_platform #13607

Merged
merged 4 commits into from
Jun 18, 2020
Merged

r/ec2_capacity_reservation - add arn attribute + support for linux sql server instance_platform #13607

merged 4 commits into from
Jun 18, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 4, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624, #13527

Release note for CHANGELOG:

resource_aws_ec2_capacity_reservation: add arn attribute.
resource_aws_ec2_capacity_reservation: add support for linux sql server types to `instance_platform` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2CapacityReservation_'
--- PASS: TestAccAWSEc2CapacityReservation_basic (45.81s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (46.20s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (78.45s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (124.33s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (46.76s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (84.28s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (46.55s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (82.73s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (115.97s)
--- PASS: TestAccAWSEc2CapacityReservation_disappears (44.23s)

@DrFaust92 DrFaust92 requested a review from a team June 4, 2020 08:09
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 4, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jun 4, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 17, 2020
@bflad bflad self-assigned this Jun 17, 2020
@bflad bflad added this to the v2.67.0 milestone Jun 17, 2020
bflad
bflad approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2CapacityReservation_basic (12.04s)
--- PASS: TestAccAWSEc2CapacityReservation_disappears (12.31s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (12.40s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (12.83s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (12.97s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (18.65s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (18.95s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (19.52s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (24.47s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (24.88s)

@bflad bflad merged commit 22e8c0f into hashicorp:master Jun 18, 2020
bflad added a commit that referenced this pull request Jun 18, 2020
@bflad
Update CHANGELOG for #13607
fbca2b4
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/ec2_capacity_reservation-arn branch June 23, 2020 11:19
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @bflad