Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

development environment make tools step fails #40485

Open
mbacchi opened this issue Dec 7, 2024 · 6 comments
Open

development environment make tools step fails #40485

mbacchi opened this issue Dec 7, 2024 · 6 comments
Labels
linter Pertains to changes to or issues with the various linters. upstream Addresses functionality related to the cloud provider.

Comments

@mbacchi
Copy link

mbacchi commented Dec 7, 2024

Description

When following the development environment setup guide in a VScode devcontainer, one of the first steps make tools fails with the error:

vscode ➜ /workspaces/terraform-provider-aws-3 (main) $ make tools
make: Installing tools...
cd .ci/providerlint && go1.23.3 install .
...
cd .ci/tools && go1.23.3 install github.com/golangci/golangci-lint/cmd/golangci-lint
# github.com/golangci/golangci-lint/pkg/golinters/tagliatelle
/go/pkg/mod/github.com/golangci/golangci-lint@v1.62.2/pkg/golinters/tagliatelle/tagliatelle.go:13:3: unknown field Rules in struct literal of type "github.com/ldez/tagliatelle".Config
make: *** [GNUmakefile:677: tools] Error 1

It appears that golangci-lint v1.62.2 does not yet require tagliatelle v0.60 (though the next release will due to this unreleased change), which was an upgraded CI dependency 5 days ago in terraform-provider-aws/.ci/tools/go.mod. This causes an inconsinstency in the tagliatelle config file that isn't tolerated in the make tools process.

References

No response

Would you like to implement a fix?

None
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 7, 2024
@drewtul
Copy link
Contributor

drewtul commented Dec 11, 2024

Looks like when that runs it installs from HEAD of main picking up their current go.mod, installing their latest release: github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.2 works fine.

@awgibbs
Copy link

awgibbs commented Dec 25, 2024

I just ran into the same problem working off of main which I pulled fresh on Christmas Day. I ultimately got through it by adding the following to .ci/tools/go.mod...

replace github.com/ldez/tagliatelle => github.com/ldez/tagliatelle v0.5.0
replace github.com/nunnatsa/ginkgolinter => github.com/nunnatsa/ginkgolinter v0.18.3

... and then within .ci/tools doing "go mod tidy" and "go1.23.3 install" and then back at the root doing "make clean" and "make tools", which was an exercise in truing up the two library versions as seen in...

https://github.com/golangci/golangci-lint/blob/v1.62.2/go.mod

... on the thought that that would play better with the pinned 1.62.2 version of golangci-lint.

@awgibbs awgibbs mentioned this issue Dec 31, 2024
Open
@jar-b jar-b added linter Pertains to changes to or issues with the various linters. upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2025
@jar-b jar-b mentioned this issue Jan 2, 2025
Merged
@jar-b
Copy link
Member

jar-b commented Jan 2, 2025

Potentially resolved with the bump to 1.63.1 in #40742.

make tools completed without issue on my machine, but will wait for confirmation from those previously experiencing issues before closing this out.

@tomhunte
Copy link
Contributor

tomhunte commented Jan 2, 2025 •
edited
Loading

I'm still seeing this when I do a clean git clone even after a complete re-installation of go on my computer.

Laptop: Apple MBP M3 - brew installed go version 1.23.4

@mbacchi
Copy link
Author

mbacchi commented Jan 3, 2025

Thanks @jar-b. This now appears to work using the original environment I had when I opened this issue. Namely running make tools after a clean git clone in a VSCode devcontainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@awgibbs @drewtul @mbacchi @jar-b @tomhunte