Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Support tags for aws_autoscaling_policy resource #37931

Open
runlevel5 opened this issue Jun 12, 2024 · 5 comments
Open

[Enhancement]: Support tags for aws_autoscaling_policy resource #37931

runlevel5 opened this issue Jun 12, 2024 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. upstream Addresses functionality related to the cloud provider.

Comments

@runlevel5
Copy link

Description

The aws_autoscaling_policy lacks the option to set tags

Affected Resource(s) and/or Data Source(s)

Affecting v5.53.0

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None
@runlevel5 runlevel5 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 12, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 12, 2024
@vijayraghav-io
Copy link

I am interested to work on this issue

@runlevel5
Copy link
Author

I am interested to work on this issue

Please go ahead

@justinretzolk justinretzolk added service/autoscaling Issues and PRs that pertain to the autoscaling service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 13, 2024
@vijayraghav-io
Copy link

vijayraghav-io commented Jun 14, 2024 •
edited
Loading

currently AWS SDK does Not support tagging AutoScalingPolicy -

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-autoscaling-scalingpolicy.html#aws-resource-autoscaling-scalingpolicy-properties
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/autoscaling#PutScalingPolicyInput
(there is not Tag property)

as a workaround the naming can be provided more descriptively

@runlevel5
Copy link
Author

🤔 if that is the case, I guess we could wait until upstream AWS SDK officially support it.

@ewbankkit ewbankkit added the upstream Addresses functionality related to the cloud provider. label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@runlevel5 @ewbankkit @vijayraghav-io @justinretzolk