Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Make it possible to configure timeout for aws_sns_platform_application #28926

Open
defigor opened this issue Jan 17, 2023 · 2 comments
Open

[Enhancement]: Make it possible to configure timeout for aws_sns_platform_application #28926

defigor opened this issue Jan 17, 2023 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@defigor
Copy link

defigor commented Jan 17, 2023

Description

aws_sns_platform_application is specified as withoutTimeout:

terraform-provider-aws/internal/service/sns/platform_application.go

Line 100 in 74fc370

func ResourcePlatformApplication() *schema.Resource {

It is unclear why it is defined in this way.
In comparison to pinpoint_apns_channel that allows to specify the timeout: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/pinpoint/apns_channel.go#L15

We are not sure if there is any underlying issue and what was the original decision to disallow specifying the timeout on aws_sns_platform_application

Please let us know if we should provide any other information.

Affected Resource(s) and/or Data Source(s)

  • aws_sns_platform_application

Potential Terraform Configuration

No response

References

We had the following issue #28925 where we waited aws_sns_platform_application to be updated for 50 minutes. It would be useful if we could override it and specify the timeout to avoid our production environment to be in unexpected state for more than 50 minutes.

Would you like to implement a fix?

None
@defigor defigor added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sns Issues and PRs that pertain to the sns service. label Jan 17, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 17, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinretzolk @defigor