Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tagging for IAM OIDC Providers #18108

Closed
ghost opened this issue Mar 15, 2021 · 3 comments
Closed

Support Tagging for IAM OIDC Providers #18108

ghost opened this issue Mar 15, 2021 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.

Comments

@ghost
Copy link

ghost commented Mar 15, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_iam_openid_connect_provider resource doesn't currently support tags, while the underlying resource in AWS does. It seems like there's a field to tag them on creation in the API, and there's also a separate API endpoint that can add tags to them once created. Being able to tag these as part of our Terraform, instead of manually later, would be useful.

New or Affected Resource(s)

  • aws_iam_openid_connect_provider

Potential Terraform Configuration

resource "aws_iam_openid_connect_provider" "default" {
  url = "https://accounts.google.com"

  client_id_list = [
    "266362248691-342342xasdasdasda-apps.googleusercontent.com",
  ]

  thumbprint_list = []

  tags = {
    foo = true
    bar = "stuff"
  }
}

References

@ghost ghost added enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. labels Mar 15, 2021
@ghost
Copy link
Author

ghost commented Mar 15, 2021

Potentially will be solved by #17964

@ewbankkit
Copy link
Contributor

@pshuman-heb Thanks for raising this issue.
It has already been noticed in #17594. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@ghost
Copy link

ghost commented Apr 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Development

No branches or pull requests

1 participant