[fix] Update dogstatsd client #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version of the client had issues connecting to abstract Unix domain sockets (e.g. `unix://@mysocket.sock`.) Also updates some test expectations.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! We're using go-metrics over at Square and found that go-metrics had trouble connecting to a dogstatsd forwarder listening on a local abstract Unix socket. After some experimentation, we found that updating the underlying dogstatsd client (to pick up DataDog/datadog-go#113) fixed the problem.
I also went through and updated a few test expectations, adding newlines where needed, so that the tests pass. I'm not sure if this was needed due to the dependency update or not.