Set SA1643 to "Error" and resolved errors. (#1835)

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
hardkoded · Oct 4, 2021 · 39594ea · 39594ea
1 parent 21367e4
commit 39594ea
Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/PuppeteerSharp.ruleset b/lib/PuppeteerSharp.ruleset
@@ -38,7 +38,7 @@
     <Rule Id="SA1512" Action="None" /> <!-- Error SA1502: Element should not be on a single line (SA1502) -->
     <Rule Id="SA1648" Action="None" /> <!-- Error SA1648: inheritdoc should be used with inheriting class (SA1648) -->
     <Rule Id="SA1616" Action="None" /> <!-- Error SA1616: Element return value documentation should have text (SA1616)-->
-    <Rule Id="SA1643" Action="None" /> <!-- Error SA1643: Destructor summary documentation should begin with standard text (SA1643) -->
+    <Rule Id="SA1643" Action="Error" /> <!-- Error SA1643: Destructor summary documentation should begin with standard text (SA1643) -->
     <Rule Id="SA1614" Action="Error" /> <!-- Error SA1614: Element parameter documentation should have text (SA1614)-->
     <Rule Id="SA1627" Action="None" /> <!-- Error SA1627: The documentation text within the \'exception\' tag should not be empty. (SA1627)-->
     <Rule Id="SA1622" Action="Error" /> <!-- Error SA1622: Generic type parameter documentation should have text. (SA1622)-->

diff --git a/lib/PuppeteerSharp/LauncherBase.cs b/lib/PuppeteerSharp/LauncherBase.cs
@@ -50,7 +50,7 @@ public LauncherBase(string executable, LaunchOptions options)
         }
 
         /// <summary>
-        /// Finalizer.
+        /// Finalizes an instance of the <see cref="LauncherBase"/> class.
         /// </summary>
         ~LauncherBase()
         {