fix: regenerate all routes on hmr, close #52

hannoeru · May 17, 2021 · d557b82 · d557b82
1 parent 525fb99
commit d557b82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/generate.ts b/src/generate.ts
@@ -142,7 +142,7 @@ export function generateClientCode(routes: Route[], options: ResolvedOptions) {
   return `${imports.join('\n')}\n\nconst routes = ${stringRoutes}\n\nexport default routes`
 }
 
-export function updateRouteFromHMR(filePath: string, routes: Route[], options: ResolvedOptions): boolean {
+export function isRouteBlockChanged(filePath: string, routes: Route[], options: ResolvedOptions): boolean {
   const routeBlock = getRouteBlock(filePath, options)
   if (routeBlock) {
     const route = findRouteByFilename(routes, filePath)

diff --git a/src/index.ts b/src/index.ts
@@ -2,7 +2,7 @@ import { resolve } from 'path'
 import type { Plugin } from 'vite'
 import { Route, ResolvedOptions, UserOptions } from './types'
 import { getPageFiles } from './files'
-import { generateRoutes, generateClientCode, updateRouteFromHMR } from './generate'
+import { generateRoutes, generateClientCode, isRouteBlockChanged } from './generate'
 import { debug, getPagesVirtualModule, isTarget, slash, replaceSquareBrackets, isDynamicRoute, isCatchAllRoute } from './utils'
 import { parseVueRequest } from './query'
 import { resolveOptions } from './options'
@@ -49,9 +49,10 @@ function pagesPlugin(userOptions: UserOptions = {}): Plugin {
       watcher.on('change', (file) => {
         const path = slash(file)
         if (isTarget(path, options) && generatedRoutes) {
-          const needReload = updateRouteFromHMR(path, generatedRoutes, options)
+          const needReload = isRouteBlockChanged(path, generatedRoutes, options)
           if (needReload) {
             debug.hmr('change', path)
+            generatedRoutes = null
             fullReload()
           }
         }