-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected call to parse_endtag #18
Labels
Comments
Hi,
You are right. I will check it tomorrow. Also if you could send a PR, that
would be great.
BR.
On Fri, Nov 1, 2019 at 6:41 PM arcane99 ***@***.***> wrote:
Hi. Getting a sporadic error 'unexpected call to parse_endtaf". I haven't
been able to replicate the issue reliably.
Occurs here in parse.py file in htmlmin.
assert rawdata[i:i+2] == "</", "unexpected call to parse_endtag"
However as a suggestion, perhaps a try except AssertionError should be
added to the reponse_minify method. This way even if the error does occur,
the final webpage is still rendered as the original unminified response is
returned.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18?email_source=notifications&email_token=ABKVF6E52N2UFZTNCT5D2A3QRRBIZA5CNFSM4JH4B5YKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWEFNLQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKVF6B6R6B7UTJQO54L5LLQRRBIZANCNFSM4JH4B5YA>
.
--
Hamid Feizabadi
Website: https://hamidfzm.ir <http://www.hamidfzm.ir>
Email: contact@hamidfzm.ir
|
Hi Hamid, created the Pull Request. Fairly small change made, hope it is okay. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closed due to inactivity, feel free to open another issue if the problem persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi. Getting a sporadic error 'unexpected call to parse_endtag". I haven't been able to replicate the issue reliably.
Occurs here in parse.py file in htmlmin.
assert rawdata[i:i+2] == "</", "unexpected call to parse_endtag"
However as a suggestion, perhaps a try except AssertionError should be added to the reponse_minify method. This way even if the error does occur, the final webpage is still rendered as the original unminified response is returned.
The text was updated successfully, but these errors were encountered: