Fix clippy

hakolao · Jan 30, 2022 · fb60589 · fb60589
1 parent 97de188
commit fb60589
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/examples/circle/render_system_plugin.rs b/examples/circle/render_system_plugin.rs
@@ -146,7 +146,7 @@ pub fn main_render_system(
                 .frame(
                     [0.0; 4],
                     before_future.into_inner(),
-                    final_image_view.clone(),
+                    final_image_view,
                     world_to_screen,
                 )
                 .unwrap();

diff --git a/examples/windowless_compute/main.rs b/examples/windowless_compute/main.rs
@@ -31,6 +31,7 @@ fn run_compute_shader_once_then_exit(
     mut app_exit_events: EventWriter<AppExit>,
 ) {
     // Create pipeline
+    #[allow(clippy::needless_question_mark)]
     let pipeline = {
         mod cs {
             vulkano_shaders::shader! {
@@ -60,7 +61,7 @@ fn run_compute_shader_once_then_exit(
     };
     // Create buffer
     let data_buffer = {
-        let data_iter = (0..65536u32).map(|n| n);
+        let data_iter = (0..65536u32).collect::<Vec<u32>>();
         CpuAccessibleBuffer::from_iter(
             vulkano_context.device(),
             BufferUsage {
@@ -94,7 +95,7 @@ fn run_compute_shader_once_then_exit(
             PipelineBindPoint::Compute,
             pipeline.layout().clone(),
             0,
-            set.clone(),
+            set,
         )
         .dispatch([1024, 1, 1])
         .unwrap();

diff --git a/src/utils.rs b/src/utils.rs
@@ -55,6 +55,12 @@ impl ImageTextureId {
     }
 }
 
+impl Default for ImageTextureId {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 pub const DEFAULT_IMAGE_FORMAT: Format = Format::R8G8B8A8_UNORM;
 
 /// Creates a storage image on device

diff --git a/src/winit_window_renderer.rs b/src/winit_window_renderer.rs
@@ -165,7 +165,7 @@ impl VulkanoWinitWindows {
         self.window_id_to_winit
             .get(&id)
             .and_then(|id| self.windows.get(id))
-            .and_then(|v_window| Some(v_window.window()))
+            .map(|v_window| v_window.window())
     }
 
     pub fn get_window_id(&self, id: winit::window::WindowId) -> Option<WindowId> {