Allow null sender when using DatagramPacketEncoder (netty#9204)

Motivation: It is valid to use null as sender so we should support it when DatagramPacketEncoder checks if it supports the message. Modifications: - Add null check - Add unit test Result: Fixes netty#9199.
haetao · Jun 3, 2019 · 7817827 · 7817827
1 parent b91889c
commit 7817827
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/codec/src/main/java/io/netty/handler/codec/DatagramPacketEncoder.java b/codec/src/main/java/io/netty/handler/codec/DatagramPacketEncoder.java
@@ -63,7 +63,7 @@ public boolean acceptOutboundMessage(Object msg) throws Exception {
             @SuppressWarnings("rawtypes")
             AddressedEnvelope envelope = (AddressedEnvelope) msg;
             return encoder.acceptOutboundMessage(envelope.content())
-                    && envelope.sender() instanceof InetSocketAddress
+                    && (envelope.sender() instanceof InetSocketAddress || envelope.sender() == null)
                     && envelope.recipient() instanceof InetSocketAddress;
         }
         return false;

diff --git a/codec/src/test/java/io/netty/handler/codec/DatagramPacketEncoderTest.java b/codec/src/test/java/io/netty/handler/codec/DatagramPacketEncoderTest.java
@@ -51,8 +51,17 @@ public void tearDown() {
 
     @Test
     public void testEncode() {
+        testEncode(false);
+    }
+
+    @Test
+    public void testEncodeWithSenderIsNull() {
+        testEncode(true);
+    }
+
+    private void testEncode(boolean senderIsNull) {
         InetSocketAddress recipient = SocketUtils.socketAddress("127.0.0.1", 10000);
-        InetSocketAddress sender = SocketUtils.socketAddress("127.0.0.1", 20000);
+        InetSocketAddress sender = senderIsNull ? null : SocketUtils.socketAddress("127.0.0.1", 20000);
         assertTrue(channel.writeOutbound(
                 new DefaultAddressedEnvelope<String, InetSocketAddress>("netty", recipient, sender)));
         DatagramPacket packet = channel.readOutbound();