Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf-based Server Implementation #270

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Protobuf-based Server Implementation #270

merged 1 commit into from
Sep 8, 2024

Conversation

JettChenT
Copy link
Member

@JettChenT JettChenT commented Jul 22, 2024 •
edited
Loading

Remaining tasks

  • On add_network, if the type is Wireguard, add the corresponding network interface and then link it
  • Timestamps for tunnel status update
  • Remove/deprecate our old json-RPC system

Testing locally

For a sanity check that this works, open three terminal tabs, and execute the below commands sequentially:

# on tab 1
sudo rm burrow.db
make daemon

# on tab 2
cargo run -- network-list
# expected result: returns an empty networks list

# on tab 3
cargo run -- network-add 1 0 ./tmp/<some-wg-config.conf>
# expected result: a new list with a network object being printed on tab 2

scrshot

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
burrow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 3:28am

@conradev conradev marked this pull request as ready for review September 8, 2024 01:53
@JettChenT
GRPC Server Support
d3c807a 
- Deprecates old json-rpc system
- Add GRPC daemon over uds
@JettChenT JettChenT merged commit e4b0f16 into main Sep 8, 2024
12 of 13 checks passed
@JettChenT JettChenT deleted the grpc-server branch September 8, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradev conradev conradev approved these changes

@malted malted Awaiting requested review from malted malted is a code owner

@Muirrum Muirrum Awaiting requested review from Muirrum Muirrum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JettChenT @conradev