Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

※important※ Mistake in nms_boxes() of util.py #19

Open
YsYusaito opened this issue Mar 18, 2021 · 3 comments
Open

※important※ Mistake in nms_boxes() of util.py #19

YsYusaito opened this issue Mar 18, 2021 · 3 comments

Comments

@YsYusaito
Copy link

YsYusaito commented Mar 18, 2021

Hi, @guichristmann

There are mistakes in NMS processing.
・errors

  1. NMS applies regardless of class.
  2. Inappropriate class reference during NMS processing

・code corrections
■utils.py - line 120,121
delete 「#」(comment out)
■utils.py - line 128,136
correct indents following bellow

※before correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□□□□□i += 1

※after correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□i += 1

By correcting like this, I could obtain appropriate inference result.

@simonm3
Copy link

simonm3 commented May 22, 2021

This is a critical bug that needs fixing asap.

@YsYusaito
Copy link
Author

@simonm3 sorry, I made a mistake.
I corrected my comment.

Hi, @guichristmann

There are mistakes in NMS processing.
・errors

  1. NMS applies regardless of class.
  2. Inappropriate class reference during NMS processing

・code corrections
■utils.py - line 120,121
delete 「#」(comment out)
■utils.py - line 128,136
correct indents following bellow

※before correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□□□□□i += 1

※after correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□□i += 1

By correcting like this, I could obtain appropriate inference result.

@AkkiSony
Copy link

Hi, @guichristmann

There are mistakes in NMS processing.
・errors

  1. NMS applies regardless of class.
  2. Inappropriate class reference during NMS processing

・code corrections
■utils.py - line 120,121
delete 「#」(comment out)
■utils.py - line 128,136
correct indents following bellow

※before correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□□□□□i += 1

※after correction
□□□if len(to_remove) != 0:
□□□□□# Remove boxes
□□□□□for r in to_remove[::-1]:
□□□□□□□del boxes[r]
□□□□□□□del scores[r]
□□□□□□□del classes[r]
□□□□i += 1

Thank you for this bug fix, you're amazin! :). Initially, I could oly detect only 1 out of 5 classes. After modifying the code, now I am able to detect 2 out of 5 classes. But other 3 classes remains undetected. :(

@YsYusaito Is there any other thing, that I have to fix and modify in the code to get all the classes detected?
Thank you again for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants