Skip to content

Commit

Permalink
Raise minimum Swift version to 5.5 (#1483)
Browse files Browse the repository at this point in the history
Motivation:

Now that 5.7 has been released NIO is due to drop support for 5.4. gRPC
Swift must do the same.

Modifications:

- Remove 5.4 from the CI
- Add 5.7 release, move 5.7-nightly to main-nightly
- Update Package.swift for the FuzzTesting subpackage to 5.7
- Update the README.md and Docc index page.

Result:

Minimum supported Swift version is 5.4
  • Loading branch information
glbrntt authored Sep 21, 2022
1 parent 04b35de commit 75030dd
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 491 deletions.
33 changes: 17 additions & 16 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,17 @@ jobs:
fail-fast: false
matrix:
include:
- image: swiftlang/swift:nightly-5.7-focal
- image: swiftlang/swift:nightly-focal
# No TSAN because of: https://github.com/apple/swift/issues/59068
# swift-test-flags: "--sanitize=thread"
- image: swift:5.7-jammy
# No TSAN because of: https://github.com/apple/swift/issues/59068
# swift-test-flags: "--sanitize=thread"
- image: swift:5.6-focal
# No TSAN because of: https://github.com/apple/swift/issues/59068
# swift-test-flags: "--sanitize=thread"
- image: swift:5.5-focal
swift-test-flags: "--sanitize=thread"
- image: swift:5.4-focal
swift-test-flags: "--sanitize=thread"
name: Build and Test on ${{ matrix.image }}
runs-on: ubuntu-latest
container:
Expand All @@ -53,7 +54,17 @@ jobs:
fail-fast: false
matrix:
include:
- image: swiftlang/swift:nightly-5.7-focal
- image: swiftlang/swift:nightly-focal
env:
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 428000
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 176000
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 174000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 181000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 181000
- image: swift:5.7-jammy
env:
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 428000
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 176000
Expand Down Expand Up @@ -83,16 +94,6 @@ jobs:
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 186000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 193000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 193000
- image: swift:5.4-focal
env:
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 459000
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 189000
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 186000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 193000
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 193000
name: Performance Tests on ${{ matrix.image }}
runs-on: ubuntu-latest
container:
Expand All @@ -108,10 +109,10 @@ jobs:
fail-fast: false
matrix:
include:
- image: swiftlang/swift:nightly-5.7-focal
- image: swiftlang/swift:nightly-focal
- image: swift:5.7-jammy
- image: swift:5.6-focal
- image: swift:5.5-focal
- image: swift:5.4-focal
name: Integration Tests on ${{ matrix.image }}
runs-on: ubuntu-latest
container:
Expand Down
2 changes: 1 addition & 1 deletion FuzzTesting/Package.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.4
// swift-tools-version:5.7
/*
* Copyright 2021, gRPC Authors All rights reserved.
*
Expand Down
Loading

0 comments on commit 75030dd

Please sign in to comment.