Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binderDied() error description to spell out the possibilities for those unfamiliar with Android internals. #11628

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update binderDied() error description to spell out the possibilities for those unfamiliar with Android internals. #11628

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a2563
Update binderDied() error description to spell out the possibilities …
jdcormie Oct 21, 2024
8cf614c
spell out peer a bit more for those unfamiliar with client/server net…
jdcormie Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
spell out peer a bit more for those unfamiliar with client/server net… 
…working terms
  • Loading branch information
@jdcormie
jdcormie authored Oct 21, 2024
commit 8cf614c968e8f67b6f0fc072f8b30bf3c17507f7
2 changes: 1 addition & 1 deletion binder/src/main/java/io/grpc/binder/internal/BinderTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) {

@Override
public synchronized void binderDied() {
shutdownInternal(Status.UNAVAILABLE.withDescription("Peer crashed, exited or was killed (binderDied)"), true);
shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true);
}

@GuardedBy("this")
Expand Down