Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csds: unskip e2e test #7502

Merged
merged 7 commits into from
Aug 15, 2024
Merged

csds: unskip e2e test #7502

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
439150f
csds: unskip e2e test
easwars Aug 12, 2024
a08e023
pass ctx to unblockResourceWatchers
easwars Aug 12, 2024
1df7d6a
review comments pass #1
easwars Aug 12, 2024
c8ceee3
delete comment
easwars Aug 12, 2024
fd7cc5a
WIP: fix flakyness in test
easwars Aug 14, 2024
9530e69
split and rewrite the test for NACK case
easwars Aug 14, 2024
6685729
final review comments
easwars Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delete comment
  • Loading branch information
@easwars
easwars committed Aug 14, 2024
commit c8ceee34a163e4273515ab1230674a82019f2cc2
2 changes: 0 additions & 2 deletions xds/csds/csds_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ func (s) TestCSDS(t *testing.T) {
t.Fatal(err)
}

// Unblock the resource watchers.
unblockResourceWatchers(ctx, t, listenerWatcher.triggerOnDoneCh, routeConfigWatcher.triggerOnDoneCh, clusterWatcher.triggerOnDoneCh, endpointsWatcher.triggerOnDoneCh)

// Verify that the xDS client reports the resources as being in "ACKed"
Expand Down Expand Up @@ -460,7 +459,6 @@ func (s) TestCSDS(t *testing.T) {
t.Fatal(err)
}

// Unblock the resource watchers once more.
unblockResourceWatchers(ctx, t, listenerWatcher.triggerOnDoneCh, routeConfigWatcher.triggerOnDoneCh, clusterWatcher.triggerOnDoneCh, endpointsWatcher.triggerOnDoneCh)

// Verify that the xDS client reports the first resource of each type as
Expand Down