Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: add support for multiple xDS clients, for fallback #7347

Merged
merged 7 commits into from
Jul 2, 2024
Merged

xds: add support for multiple xDS clients, for fallback #7347

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3e2ec7
xds: add support for multiple xDS clients, for fallback
easwars Jun 17, 2024
4162d1d
ensure args are passed in properly to t.Logf
easwars Jun 24, 2024
3892040
deflake existing tests
easwars Jun 25, 2024
9d704f0
add a new test with many to many xds clients to servers
easwars Jun 25, 2024
0ea40bf
review comments pass #1
easwars Jun 27, 2024
6079e82
review comments pass #2
easwars Jun 28, 2024
ef92a2f
skip test in arm64
easwars Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure args are passed in properly to t.Logf
  • Loading branch information
@easwars
easwars committed Jun 24, 2024
commit 4162d1d86ae475e09c16e64d315ebaffa089eeaa
8 changes: 4 additions & 4 deletions internal/testutils/xds/e2e/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ type serverLogger struct {
}

func (l serverLogger) Debugf(format string, args ...any) {
l.logger.Logf(format, args)
l.logger.Logf(format, args...)
}
func (l serverLogger) Infof(format string, args ...any) {
l.logger.Logf(format, args)
l.logger.Logf(format, args...)
}
func (l serverLogger) Warnf(format string, args ...any) {
l.logger.Logf(format, args)
l.logger.Logf(format, args...)
}
func (l serverLogger) Errorf(format string, args ...any) {
l.logger.Logf(format, args)
l.logger.Logf(format, args...)
}