Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdsbalancer: switch cluster watch to generic xDS client API #6600

Merged
merged 8 commits into from
Sep 12, 2023
Merged

cdsbalancer: switch cluster watch to generic xDS client API #6600

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e8d43f5
cdsbalancer: switch cluster watch to generic xDS client API
easwars Aug 29, 2023
d64a13b
add the actual max depth value to the error string
easwars Sep 8, 2023
d6c60b2
fix a comment for correctness
easwars Sep 8, 2023
e338278
other review comments
easwars Sep 8, 2023
822bc0b
ensure maximal graph coverage even during errors
easwars Sep 12, 2023
d16a312
last round of review comments
easwars Sep 12, 2023
c5e5b53
rename one of the tests
easwars Sep 12, 2023
cd8e820
rename the test file
easwars Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix a comment for correctness
  • Loading branch information
@easwars
easwars committed Sep 8, 2023
commit d6c60b290aee946cd8c422f4faa2c4d2bbd6424a
2 changes: 1 addition & 1 deletion xds/internal/balancer/cdsbalancer/cdsbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func (b *cdsBalancer) onClusterUpdate(name string, update xdsresource.ClusterUpd
// an update to it.
childCfg := &clusterresolver.LBConfig{
DiscoveryMechanisms: dms,
// The LB policy is configured by the aggregate cluster.
// The LB policy is configured by the root cluster.
XDSLBPolicy: b.watchers[b.lbCfg.ClusterName].lastUpdate.LBPolicy,
}
cfgJSON, err := json.Marshal(childCfg)
Expand Down