Skip to content

Commit

Permalink
Address the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
adelez committed May 4, 2017
1 parent 7ddf89f commit d010e79
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion grpclb.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const (
)

// AddrMetadataGRPCLB contains the information the name resolver for grpclb should provide. The
// name resolver used by grpclb balancer is required to provide this type of metadata in
// name resolver used by the grpclb balancer is required to provide this type of metadata in
// its address updates.
type AddrMetadataGRPCLB struct {
// AddrType is the type of server (grpc load balancer or backend).
Expand Down
26 changes: 13 additions & 13 deletions metadata/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func DecodeKeyValue(k, v string) (string, string, error) {
// two convenience functions New and Pairs to generate MD.
type MD map[string][]string

// New creates a MD from given key-value map.
// New creates an MD from a given key-value map.
// Keys are automatically converted to lowercase.
func New(m map[string]string) MD {
md := MD{}
Expand Down Expand Up @@ -81,19 +81,19 @@ func Pairs(kv ...string) MD {
return md
}

// Len returns the number of items in MD.
// Len returns the number of items in md.
func (md MD) Len() int {
return len(md)
}

// Copy returns a copy of MD.
// Copy returns a copy of md.
func (md MD) Copy() MD {
return Join(md)
}

// Join joins any number of MDs into a single MD.
// Join joins any number of mds into a single MD.
// The order of values for each key is determined by the order in which
// the MDs containing those values are presented to Join.
// the mds containing those values are presented to Join.
func Join(mds ...MD) MD {
out := MD{}
for _, md := range mds {
Expand All @@ -112,12 +112,12 @@ func NewContext(ctx context.Context, md MD) context.Context {
return NewOutgoingContext(ctx, md)
}

// NewIncomingContext creates a new context with incoming MD attached.
// NewIncomingContext creates a new context with incoming md attached.
func NewIncomingContext(ctx context.Context, md MD) context.Context {
return context.WithValue(ctx, mdIncomingKey{}, md)
}

// NewOutgoingContext creates a new context with outgoing MD attached.
// NewOutgoingContext creates a new context with outgoing md attached.
func NewOutgoingContext(ctx context.Context, md MD) context.Context {
return context.WithValue(ctx, mdOutgoingKey{}, md)
}
Expand All @@ -127,17 +127,17 @@ func FromContext(ctx context.Context) (md MD, ok bool) {
return FromIncomingContext(ctx)
}

// FromIncomingContext returns the incoming MD in ctx if it exists. The
// returned md should be immutable. Writing to it may cause races.
// Modification should be made to copies of the returned md.
// FromIncomingContext returns the incoming metadata in ctx if it exists. The
// returned MD should be immutable. Writing to it may cause races.
// Modification should be made to copies of the returned MD.
func FromIncomingContext(ctx context.Context) (md MD, ok bool) {
md, ok = ctx.Value(mdIncomingKey{}).(MD)
return
}

// FromOutgoingContext returns the outgoing MD in ctx if it exists. The
// returned md should be immutable. Writing to it may cause races.
// Modification should be made to the copies of the returned md.
// FromOutgoingContext returns the outgoing metadata in ctx if it exists. The
// returned MD should be immutable. Writing to it may cause races.
// Modification should be made to the copies of the returned MD.
func FromOutgoingContext(ctx context.Context) (md MD, ok bool) {
md, ok = ctx.Value(mdOutgoingKey{}).(MD)
return
Expand Down

0 comments on commit d010e79

Please sign in to comment.