Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .map() that returns ResponseStream instead of Stream #689

Open
maherjaafar opened this issue Jan 31, 2024 · 5 comments
Open

Support .map() that returns ResponseStream instead of Stream #689

maherjaafar opened this issue Jan 31, 2024 · 5 comments
Labels
type-enhancement

Comments

@maherjaafar
Copy link

maherjaafar commented Jan 31, 2024 •
edited
Loading

keeping the return type as ReponseStream to be able to call .cancel() after using .map()

Used version: grpc: 3.2.4

Example

    final ReponseStream myStream = _client
        .myReponseStream
        .listen((event) => event.map((event) => event.value));

Expected result: I expect to get result of type ReponseStream but the result will be of type Stream

Actual result: Stream
@maherjaafar
Copy link
Author

Any updates?

@maherjaafar
Copy link
Author

@mosuem any updates?

@mosuem
Copy link
Contributor

mosuem commented Apr 19, 2024

Hi @maherjaafar, I am not sure what you mean. Where does this WatchEventsRequest come from?

@maherjaafar
Copy link
Author

@mosuem It's just an example. I changed it⬆️

The issue arises when I use .map, as it converts it to a Stream instead of a ResponseStream. Consequently, I lose the ability to call myResponseStream.cancel() to cancel the stream.

@teamplayer3
Copy link

teamplayer3 commented Dec 28, 2024 •
edited
Loading

Any update? I think the better question is, when is the Response Stream canceled? When the response is mapped and a stream is the result, how to cancel the response stream by the mapped stream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mosuem @maherjaafar @teamplayer3