Updating Ix-Async to System Interactive and nuget #7623
Conversation
apolcyn
force-pushed
the
sys_inter_with_nuget
branch
from
b4e01c4 to
2717aea
Compare
|
No success yet in removing the workaround of removing the runtime nodes in some of the test project project.jsons. Currently planning on going back to make coreclr builds work in a separate PR. It also seems like dotnet cli has much better support on mac and linux than nuget does, so I think that tests and builds should use that, but this looks like it will require a lot more changes, so planning to do them in a separate PR. #7629 |
|
test this please |
1 similar comment
|
test this please |
apolcyn
assigned murgatroid99, nicolasnoble and apolcyn and unassigned murgatroid99, nicolasnoble and apolcyn
|
I think test failures now are flakes. test this please |
|
Most of these failures seem like flakes or issues with dependencies, but some failures in unit tests here look are intermittent, hopefully not due too the async library change... test this please |
|
have not been able to reproduce the error in unit tests on jenkins so far. test this please |
|
test this please |
|
failures here now seem to be unrelated build issues. the error on csharp tests seems to be a recurring compiler error of third_party/zlib/gzlib.c, happening mac-node-1. |
| @@ -35,7 +35,8 @@ setlocal | |||
| cd /d %~dp0\..\.. | |||
|
|
|||
| @rem Location of nuget.exe | |||
| set NUGET=C:\nuget\nuget.exe | |||
| @rem TODO: change this before submitting. This is only for migrating nuget | |||
| set NUGET=C:\nuget_temp\nuget.exe | |||
There was a problem hiding this comment.
yes this should be changed, changing this now
|
test this please |
|
Haven't been able to reproduce the failing csharp unit test seen on jenkins. Interop builds seem to be failing in general, but csharp basic tests are passing here. |
|
Have not been able to reproduce the error in unit tests yet. Filed an issue for it here: #7667 |
This updates from Ix-Async to System.Interactive.Async, using an updated nuget client.
Unfortunately it seems like the runtime node sections of some test projects need to be in order to workaround some issues with nuget. This is meant to replace #7519