Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance versions from 0.14 -> 1.0.0-pre1 #7413

Merged
merged 8 commits into from
Jul 19, 2016
Merged

Advance versions from 0.14 -> 1.0.0-pre1 #7413

merged 8 commits into from
Jul 19, 2016

Conversation

jcanizales
Copy link
Contributor

@jcanizales jcanizales commented Jul 15, 2016 •
edited
Loading

Pending after this:

  • Test by pointing BoringSSL.podspec to latest commit of its repo.
  • Tag that commit of the BoringSSL repo.
  • Tag gRPC repo.
  • Build the plugin, zip it, and add it to the release.
  • Push Cocoapods to trunk.

@jcanizales
Advance versions from 0.14 -> 1.0
854b81a 
Pending:

- Tag BoringSSL repo.
- Tag gRPC repo.
- Build the plugin, zip it, and add it to the release.
- Push Cocoapods to trunk.
@jcanizales jcanizales added this to the 2016/05/21 Milestone milestone Jul 15, 2016
@jcanizales
Copy link
Contributor Author

Argh, of course this fails until we tag the BoringSSL repo...

@muxi
Copy link
Member

muxi commented Jul 18, 2016

templates/gRPC-Core.podspec.template may need to be updated too

@jcanizales
Copy link
Contributor Author

Good catch!

@jcanizales
Copy link
Contributor Author

Note that the 3 Travis failures are expected, as the apps under /examples use the released pods, and 1.0 isn't released yet. The apps under /src/objective-c/examples compile everything from sources, same as the tests, so they pass.

@jcanizales jcanizales changed the title Advance versions from 0.14 -> 1.0 Advance versions from 0.14 -> 1.0.0-pre1 Jul 19, 2016
@makdharma
Copy link
Contributor

Since all the changes are about obj-c, and the tests are expected to fail because cocoapods doesn't know about 1.0.0-pre1, I'm merging by force.

@makdharma makdharma merged commit 5e93d3f into grpc:v1.0.x Jul 19, 2016
@jcanizales jcanizales deleted the p0-advance-versions-to-1 branch July 19, 2016 01:04
@jcanizales jcanizales mentioned this pull request Aug 18, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
@lock lock bot unassigned makdharma Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@muxi muxi

Labels
cla: yes lang/ObjC
Projects
None yet
Milestone
2016/05/21 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcanizales @muxi @makdharma @googlebot