-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: implement custom_metadata interop, status_code_and_message, unimplemented_method tests #6631
PHP: implement custom_metadata interop, status_code_and_message, unimplemented_method tests #6631
Conversation
392bf9f
to
6cd7122
Compare
This needs #6632 to be merged first |
Friendly ping |
e0946b2
to
28408b8
Compare
Another ping: this is just the custom_metadata interop test for PHP now |
LGTM |
test this please |
re-based and PHP tests passed |
Let's un-blacklist the custom_metadata interop test for PHP, otherwise this change is pointless. https://github.com/grpc/grpc/blob/master/tools/run_tests/run_interop_tests.py#L255 |
28408b8
to
cb18b66
Compare
cb18b66
to
8939140
Compare
@murgatroid99 Please review this again, thanks! So I end up implementing all of Two things:
|
The existing |
@murgatroid99 Thanks for the pointer. Fixed by copying and using |
LGTM |
Implement
custom_metadata
interop test for PHP. Fixes #6579