Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate Python build directory naming conflict #4957

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Mitigate Python build directory naming conflict #4957

merged 1 commit into from
Jan 29, 2016
+4 −0

Conversation

soltanmm
Copy link
Contributor

On Mac and Windows, the default directory name conflicts with the BUILD file we have. This is relevant to people building from source.

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@nathanielmanistaatgoogle
Copy link
Member

Change content looks good; merge at your leisure.

From the last time we talked about this I got the impression that you were having a hard time with this problem - was it a case of finding the solution being difficult but the solution itself being simple?

@soltanmm
Copy link
Contributor Author

It was a case of me assuming that Mac OS was case sensitive for a number of years and then finding out I was utterly, horribly, ineffably wrong.

@soltanmm-google
Mitigate Python build directory naming conflict
1a54e5c 
On Mac and Windows, the default directory name conflicts with the BUILD
file we have.
@ctiller
Copy link
Member

ctiller commented Jan 29, 2016

Once upon a time you could choose (at installation time) whether to be case
sensitive or not. Hilarity ensued.

On Thu, Jan 28, 2016 at 4:51 PM Masood Malekghassemi <
notifications@github.com> wrote:

It was a case of me assuming that Mac OS was case sensitive for a number
of years and then finding out I was utterly, horribly, ineffably wrong.

—
Reply to this email directly or view it on GitHub
#4957 (comment).

soltanmm added a commit that referenced this pull request Jan 29, 2016
@soltanmm
Merge pull request #4957 from soltanmm/bob
0f1d42e 
Mitigate Python build directory naming conflict
@soltanmm soltanmm merged commit 0f1d42e into grpc:master Jan 29, 2016
@soltanmm soltanmm deleted the bob branch January 29, 2016 15:50
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nathanielmanistaatgoogle nathanielmanistaatgoogle

Labels
cla: yes lang/Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soltanmm @grpc-kokoro @nathanielmanistaatgoogle @ctiller @googlebot @soltanmm-google