Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server.KillAsync() and improve abandoned call test #4436

Merged
merged 8 commits into from
Dec 15, 2015
Merged

Fix server.KillAsync() and improve abandoned call test #4436

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03c0106
split up C# tests into separate processes
jtattermusch Dec 11, 2015
3ac274f
start using Ignore attribute for performance tests
jtattermusch Dec 11, 2015
450b281
temporarily disable StatusCodeAndMessage test
jtattermusch Dec 11, 2015
839dc96
temporarily disable UnimplementedMethod test
jtattermusch Dec 11, 2015
62d6c20
add C# sanity test
jtattermusch Dec 14, 2015
1b8210f
fix completion queue test
jtattermusch Dec 14, 2015
7608c96
fix bug in Server.KillAsync()
jtattermusch Dec 15, 2015
d63b1d6
Fix AbandonedCall test
jtattermusch Dec 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix AbandonedCall test
  • Loading branch information
@jtattermusch
jtattermusch committed Dec 15, 2015
commit d63b1d62b13914462cfee7ed6137395179e66eb0
11 changes: 7 additions & 4 deletions src/csharp/Grpc.Core.Tests/ShutdownTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,20 @@ public void Init()
}

[Test]
public async Task AbandonedCall()
public async Task AbandonedCall_ServerKillAsync()
{
var readyToShutdown = new TaskCompletionSource<object>();
helper.DuplexStreamingHandler = new DuplexStreamingServerMethod<string, string>(async (requestStream, responseStream, context) =>
{
readyToShutdown.SetResult(null);
await requestStream.ToListAsync();
});

var call = Calls.AsyncDuplexStreamingCall(helper.CreateDuplexStreamingCall(new CallOptions(deadline: DateTime.UtcNow.AddMilliseconds(1))));
var call = Calls.AsyncDuplexStreamingCall(helper.CreateDuplexStreamingCall());
await readyToShutdown.Task; // make sure handler is running

channel.ShutdownAsync().Wait();
server.ShutdownAsync().Wait();
await channel.ShutdownAsync(); // channel.ShutdownAsync() works even if there's a pending call.
await server.KillAsync(); // server.ShutdownAsync() would hang waiting for the call to finish.
}
}
}