Changed GRPCCall import to class forward declaration #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GRPCCall.h file is already correctly imported in the GRPCRequestHeaders.m implementation file. This header shouldn’t need to import GRPCCall and should specify a class forward declaration for reference.
|
Can one of the admins verify this patch? |
jcanizales
added a commit
that referenced
this pull request
Sep 23, 2015
Changed GRPCCall import to class forward declaration
|
And this now prevents #3372 since 0.11.1 did something different. |
|
Aka, something needs to happen with that PR - either roll it back, wait for #3372 to be merged, then do it again, or fix it in the release-0_11 branch too. |
|
They should be the same now (except that it took two different commits here what was done in one there) - is the merge happy with it? Sorry for blocking! |
|
Yep, it's good now. @dgquintas can merge now :-) |
|
Very quickly running Jenkins against the latest commits and then merging quickly before Jorge makes his move again :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GRPCCall.h file is already correctly imported in the
GRPCRequestHeaders.m implementation file. This header shouldn’t need to
import GRPCCall and should specify a class forward declaration for
reference.