Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: refactor common code for polling-based resolvers #28979

Merged
merged 13 commits into from
Mar 10, 2022
Merged

resolver: refactor common code for polling-based resolvers #28979

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1e100d4
resolver: refactor common code for polling-based resolvers
markdroth Feb 26, 2022
38be9d4
remove now-incorrect assertion
markdroth Feb 26, 2022
6a54837
fix cleanup bug
markdroth Feb 28, 2022
139ba58
add missing include guards
markdroth Feb 28, 2022
1585c4b
portability fix
markdroth Feb 28, 2022
dd51188
fix some lifetime issues
markdroth Feb 28, 2022
d9ca2c3
plumb tracer into PollingResolver
markdroth Feb 28, 2022
75e9d7f
fix pollset_set propagation
markdroth Feb 28, 2022
dabb4a7
increase RPC timeout in python DNSResolverTest
markdroth Mar 1, 2022
aacf595
add dns_resolver tracer and fix ref leak
markdroth Mar 2, 2022
08326c1
Merge remote-tracking branch 'upstream/master' into resolver_polling
markdroth Mar 2, 2022
5ae9659
code review comments
markdroth Mar 4, 2022
4fc88ca
check shutdown_ in OnNextResolutionLocked()
markdroth Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove now-incorrect assertion
  • Loading branch information
@markdroth
markdroth committed Feb 26, 2022
commit 38be9d4a6f616a034b8697fca5b12c7b3f222dcd
1 change: 0 additions & 1 deletion src/core/ext/filters/client_channel/resolver/polling_resolver.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ void PollingResolver::OnRequestComplete(Result result) {
}

void PollingResolver::OnRequestCompleteLocked(Result result) {
GPR_ASSERT(request_ != nullptr);
request_.reset();
if (shutdown_) return;
if (result.service_config.ok() && result.addresses.ok()) {
Expand Down