Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bloat_diff #12832

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Introduce bloat_diff #12832

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a3805
Submodule bloaty mcbloatface
ctiller Oct 4, 2017
e3dbf76
Initial implementation of bloat_diff
ctiller Oct 4, 2017
f734e73
Better output
ctiller Oct 4, 2017
9125923
Configure tool to run
ctiller Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better output
  • Loading branch information
@ctiller
ctiller committed Oct 4, 2017
commit f734e732e3aa94c2db0550e36d007f0114338560
9 changes: 5 additions & 4 deletions tools/profiling/bloat/bloat_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,15 @@ def build(where):
old_version = glob.glob('bloat_diff_old/opt/%s' % lib)
new_version = glob.glob('bloat_diff_new/opt/%s' % lib)
assert len(new_version) == 1
cmd = 'third_party/bloaty/bloaty -d compileunits,symbols'
if old_version:
assert len(old_version) == 1
text += subprocess.check_output('third_party/bloaty/bloaty %s -- %s' %
(new_version[0], old_version[0]),
text += subprocess.check_output('%s %s -- %s' %
(cmd, new_version[0], old_version[0]),
shell=True)
else:
text += subprocess.check_output('third_party/bloaty/bloaty %s' %
(new_version[0]),
text += subprocess.check_output('%s %s' %
(cmd, new_version[0]),
shell=True)
text += '\n\n'

Expand Down