Fix unnecessary slice moving in slice_buffer.c:maybe_embiggen #10211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreecha
reviewed
Mar 18, 2017
src/core/lib/slice/slice_buffer.c
Outdated
| } else { | ||
| if (sb->base_slices != sb->slices) { |
There was a problem hiding this comment.
It would be good to do this before growing the capacity: i.e line 54 above sb->capacity = GROW(sb->capacity)
Because after the memmove, we might have some space and no longer have to do a gpr_realloc
So perhaps it would be just good do the memmove just before checking for if (slice_count == sb->capacity)..
i.e something like:
static void maybe_embiggen(grpc_slice_buffer *sb) {
size_t slice_offset = (size_t)(sb->slices - sb->base_slices);
size_t slice_count = sb->count + slice_offset;
if (slice_count == sb->capacity && sb->base_slices != sb->slices) {
/* do the memmove */
/* re-calculate slice_offset or rather just reset slice_count to sb->count */
}
..
}
sreecha
approved these changes
Mar 28, 2017
|
test this please |
|
|
gRPC_interop_pull_requests - #9011 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid moving slices unnecessarily when invoking
grpc_slice_buffer_addthat impacted performance.Cherry-picked from #9626 as it is still going to take some time to submit that PR, while this change is orthogonal and going to benefit widely.