gRPC C++ doxygen audit suggestions/change requests #11022
Closed
Description
grpc::Server.Waitsays blocks till “all work” is complete. Please consider being more explicit with what is “all work”? pending RPCs? Under what circumstances should the user need to call it?ServerBuilder::SyncServerOptionandSetSyncServerOptionlacks documentationServerBuilder::AddCompletionQueuetalks at length about whyis_frequently_polledshould not be set to false, but does not mention an example valid use case for that scenario.CreateChannel: clarify what a “lame” cannel is.security/auth_metadata_processor.h: add class description comment- Comments in
async_generic_service - Add documentation for
impl/codegen/{call.h,service.h,rpc_method.h}even though they are underimpl?