Don't show 'Trigger:' header in Trigger component for Trigger CRD

The details page for a `Trigger` resource already has a heading showing the resource name so there's no need to duplicate it in the block rendered by the Trigger component. We still display this heading when the component is used on the `EventListener` page.
grofers · Apr 23, 2021 · 5b68115 · 5b68115
1 parent d46a169
commit 5b68115
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/components/src/components/Trigger/Trigger.js b/packages/components/src/components/Trigger/Trigger.js
@@ -45,7 +45,10 @@ const Trigger = ({ intl, namespace, trigger }) => {
 
   const { bindings, interceptors, template } = trigger.spec || trigger;
   const triggerTemplateName = template.ref || template.name;
-  const triggerName = trigger.metadata?.name || trigger.name;
+  // we deliberately don't get the name from a Trigger resource here
+  // as it will already have a heading on the page so we only want to display
+  // a header in this component when it's for a trigger in an EventListener
+  const triggerName = trigger.name;
 
   return (
     <div>

diff --git a/src/containers/Trigger/Trigger.test.js b/src/containers/Trigger/Trigger.test.js
@@ -127,6 +127,7 @@ describe('TriggerContainer', () => {
 
   it('renders the trigger resource', async () => {
     const triggerName = 'fake_triggerName';
+    const templateName = 'fake_templateName';
     const fetchTriggerSpy = jest
       .fn()
       .mockImplementation(() => Promise.resolve());
@@ -144,10 +145,11 @@ describe('TriggerContainer', () => {
         match={match}
         trigger={{
           metadata: { name: triggerName },
-          spec: { template: { ref: 'foo' } }
+          spec: { template: { ref: templateName } }
         }}
       />
     );
-    expect(queryByText(`Trigger: ${triggerName}`)).toBeTruthy();
+    expect(queryByText(triggerName)).toBeTruthy();
+    expect(queryByText(templateName)).toBeTruthy();
   });
 });